Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Add pagination guidance. #1218

Merged
merged 25 commits into from
Jun 16, 2021
Merged

USWDS - Add pagination guidance. #1218

merged 25 commits into from
Jun 16, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Apr 29, 2021

Description

Adds guidance for new Pagination component. Closes #1205 and closes uswds/uswds/issues/4158.

Preview link →

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

mejiaj added 3 commits April 29, 2021 13:58
- Only run necessary tasks
- Run prettier on rendered templates for  component code examples
@mejiaj mejiaj marked this pull request as ready for review April 30, 2021 16:05
@mejiaj
Copy link
Contributor Author

mejiaj commented Jun 16, 2021

LGTM!

@thisisdano thisisdano merged commit 81892b2 into main Jun 16, 2021
@thisisdano thisisdano deleted the jm-add-pagination-guidance branch June 16, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spanish version of pagination component Pagination: create guidance page
2 participants