USWDS - Links: Update external link guidance.#1225
Merged
Conversation
- Also adds support for custom icon sprite
…put prefix/suffix, and modal.
Keys added to IDs to fix accessibility issues on pages like `/components/button-group` where the IDs were being flagged as duplicate.
4 tasks
katieekline
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates external link guidance based on the revised guidance 🔒.
Closes #1222.
Preview
Link guidance →
Additional information
usa-linkpackage in USWDS. [USWDS - Link: Create missingusa-linkcomponent package. uswds#4193]Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.