Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Links: Update external link guidance. #1225

Merged
merged 31 commits into from
Jun 17, 2021
Merged

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented May 11, 2021

Description

Updates external link guidance based on the revised guidance 🔒.

Closes #1222.

Preview

Link guidance →

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review May 12, 2021 18:05
@mejiaj mejiaj requested a review from katieekline May 12, 2021 18:09
@mejiaj mejiaj requested a review from thisisdano May 24, 2021 16:50
@thisisdano thisisdano merged commit c11fa69 into main Jun 17, 2021
@thisisdano thisisdano deleted the dw-update-link-guidance branch June 17, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish revised link guidance to site
3 participants