Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Accessibility: Add new content to a11y page. #1230

Merged
merged 17 commits into from
May 20, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented May 18, 2021

Description

Closes uswds/uswds/issues/4188. Adds new content to Accessibility page.

Revised guidance 🔒

Preview

Accessibility page →

Additional information

N/A

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@thisisdano thisisdano marked this pull request as ready for review May 20, 2021 07:06
- It's not only part of our mission to embrace accessibility in our own work, but to do what we can to encourage it.
- **We prioritize accessibility issues.** We will work hard to fix accessibility-related issues quickly, and to get them into the next available release. Accessibility is a mission-critical service for USWDS, and we want to know when there's an opportunity to fix something that's broken or improve something that could be better.

While we conduct extensive research during the design and development of components, it is impossible to predict every use case for accessibility and usability overall. That is why we encourage you to [contribute to the community]({{ site.baseurl }}/about/community) by providing feedback on how a component is working on your site. We also recommend performing your own user testing at the page level to gauge the usability of a component within context. We welcome any and all findings and feedback as we work to identify and prioritize improvements to our components and guidance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisdano @mejiaj Not sure on the call to add Digital.gov, plain language.gov or usability.gov links into this section. Could you weigh in on this and determine if those should be added to this paragraph -- or at least to the Govt A11y Resources section below? Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good ideas

Copy link

@KMullan944 KMullan944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mejiaj I added editorial notes to make tweaks to the sections Sarah found needed tweaks. You'll see my changes in Comments. Just need Dan to weigh in on the resources she suggested linking to. Thanks!

@mejiaj
Copy link
Contributor Author

mejiaj commented May 20, 2021

Made some changes based on feedback. Thanks for the review @sknep!

@thisisdano thisisdano dismissed KMullan944’s stale review May 20, 2021 17:10

Changes implemented

Copy link

@KMullan944 KMullan944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@thisisdano thisisdano merged commit c4e9855 into main May 20, 2021
@thisisdano thisisdano deleted the jm-update-a11y-page branch May 20, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update accessibility page
4 participants