Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Implementations: Add Drupal CKEditor and paragraph modules. #1233

Merged
merged 11 commits into from
Jul 27, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented May 27, 2021

Description

Closes uswds/uswds/issues/4208. Adds two Drupal modules to implementations page.

Preview

Implementations page →

Additional information

⚠We should consider removing outdated or archived implementations.

These are some implementations which have been archived:

There's also:

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review May 27, 2021 14:31
@mejiaj
Copy link
Contributor Author

mejiaj commented Jun 15, 2021

@thisisdano thoughts on removing the implementations listed in additional information section?

@thisisdano
Copy link
Member

I don't think we should remove them (since they could still be helpful in some way, even if they are out of date), but we should add a usa-label to the start of each of the Notes sections, with an Archived or Stale(?) label if the implementation is archived or no longer maintained.

Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kissing-fingers:

@thisisdano thisisdano merged commit f1cfc9e into main Jul 27, 2021
@thisisdano thisisdano deleted the jm-add-drupal-implementations branch July 27, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementations page: table
2 participants