Finalize link guidance #1249
Merged
Finalize link guidance #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisdano
commented
Jul 29, 2021
Comment on lines
+1433
to
+1443
| @include external-link( | ||
| usa-icons-bg/launch--blue-60v, | ||
| usa-icons-bg/launch--blue-70v | ||
| ); | ||
| } | ||
|
|
||
| .usa-link--alt#{$external-href} { | ||
| @include external-link( | ||
| usa-icons-bg/launch--gray-5, | ||
| usa-icons-bg/launch--white | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This adds icons of the proper color to non-.gov links. (There are existing rules that hide these icons on the nav, buttons, etc)
Comment on lines
-3726
to
-3729
| [href^="http"]:not([href*=".gov"])::after { | ||
| display: none; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed this rule to allow external link icons
package.json
Outdated
| "sass": "^1.35.1", | ||
| "snyk": "^1.667.0", | ||
| "uswds": "^2.12.0", | ||
| "uswds": "github:uswds/uswds#dw-external-link", |
Contributor
Author
There was a problem hiding this comment.
Using an icon feature branch — this will need to be updated (and package-lock generated) after we merge that branch into develop
mejiaj
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes our link guidance and adds the findings from our external link indicator research. It also adds external link icons to most text links throughout the site.