Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - About: add security updates. #1304

Merged
merged 27 commits into from
Nov 5, 2021
Merged

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Oct 29, 2021

Description

Closes #1297. Added a section for security related updates on USWDS. This new content is part of a collection called _security_updates. A security update contains:

---
title: What we did in present tense
excerpt: A brief description of when the change happened and what it does
---

Description

## When we made this change
Link to which version it was fixed in.

## Who should update
What versions of USWDS does this affect.

## Updating to USWDS 2.x.x
List of breaking changes when upgrading.

Additional information

N/A

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

layout: styleguide
title: Security
category: About
lead: Developing and using USWDS with security in mind
subnav:
type: security_updates
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ties the content in security_updates collection to Security in sidenav. Otherwise the current status doesn't display properly.

@mejiaj mejiaj marked this pull request as ready for review November 1, 2021 17:32
thisisdano
thisisdano previously approved these changes Nov 5, 2021
@thisisdano thisisdano dismissed their stale review November 5, 2021 16:58

URLs don't actually work

@thisisdano thisisdano merged commit 0fc3deb into main Nov 5, 2021
@thisisdano thisisdano deleted the jm-security-page-updates branch November 5, 2021 20:31
@crazEmama1
Copy link

L

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft update to security page
3 participants