Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting Started Devs: Copy edits #1370

Merged
merged 19 commits into from
Dec 15, 2021
Merged

Getting Started Devs: Copy edits #1370

merged 19 commits into from
Dec 15, 2021

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Dec 9, 2021 •
edited
Loading

Description


Preview link →

TK

Additional information

TK

Include any of the following (as necessary):

  • Relevant research and support documents
  • Type of content review needed: stylistic or copy editing
  • Screenshot images
  • Notes
  • etc.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

mejiaj and others added 10 commits December 9, 2021 09:38
@mejiaj
Fix step 1 link in Phase two.
0ec7d4f
@mejiaj
Add missing del package to uswds-gulp note.
407b442
@mejiaj
Add note about using copy commands separately.
bc5804a
@mejiaj
Remove duplicate note: in site note.
cf99409
@mikki-stacey
Update phase-two.md
8f9f2dc
@mikki-stacey
U3 edits
70eb20c 
Ensured we consistently use "design tokens" rather than just "tokens."
Clarified that a different set of instructions are provided on GitHub.
Introduced the USWDS community as a resource.
Merged "Key concepts" into "Before getting started."
@mikki-stacey
U3 validation updates
4f141f9 
Added Sass requirements to Step 2.
@mikki-stacey
U3 validation updates
2fb00f2 
Per our 12/13 meeting:
-Added `del` in command line in step 2
-Removed the code block with basic defaults and added defaults as comment lines in the previous code block
-Removed watch command (which will be added to phase 3)
@mikki-stacey
U3 Validation update
dc3772b 
Revised for concision.
@mikki-stacey
U3 validation updates
0900be8 
Added language to create a better sense of conclusion.
@thisisdano thisisdano marked this pull request as ready for review December 15, 2021 06:42
@thisisdano thisisdano merged commit 8a8b212 into main Dec 15, 2021
@thisisdano thisisdano deleted the jm-getting-started-devs-edits branch December 15, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejiaj @thisisdano @mikki-stacey