Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started for Devs - move resources to subnav #1422

Merged
merged 8 commits into from
Feb 17, 2022

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Feb 1, 2022

The Getting Started for Devs resources currently live at the bottom of the 'Phase: 3 customize' page. This PR moves the resources information to its own page and includes it in the subnav next to Phase 1-3.

Addresses Issue #1421

@amyleadem amyleadem linked an issue Feb 2, 2022 that may be closed by this pull request
@sofya-UX
Copy link

sofya-UX commented Feb 2, 2022

Thanks @amyleadem looks good to me. @mikki-stacey could you give this a look, too? TY

@mikki-stacey
Copy link
Contributor

@amyleadem , thank you for working on this PR! Just one more change: "Continue learning" and "Contribute to the codebase" should be a heading level below "Stay involved."

@amyleadem
Copy link
Contributor Author

@amyleadem , thank you for working on this PR! Just one more change: "Continue learning" and "Contribute to the codebase" should be a heading level below "Stay involved."

@mikki-stacey thanks for the response! I am not sure I understand. Are you asking for those two headers be downgraded from h2 to h3?

@mikki-stacey
Copy link
Contributor

@amyleadem , that is correct.

For total clarity—Nothing needs to change in the side nav. Let me know if there's better/more specific language I should be using to describe formatting in GitHub!

@amyleadem amyleadem marked this pull request as ready for review February 3, 2022 16:03
@amyleadem
Copy link
Contributor Author

Hi @mikki-stacey, is this better?

@mikki-stacey
Copy link
Contributor

@amyleadem , perfect—thank you!

@mejiaj mejiaj merged commit 7d7878a into main Feb 17, 2022
@mejiaj mejiaj deleted the al-add-getting-started-resources branch February 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulling all Resources up onto main GS for Dev page
4 participants