Repository navigation
Dev guide updates uswds compile - #1424
Merged
Merged
Conversation
Removed unnecessary hyphens.
Addressed capitalization errors in the lead text. Added end punctuation for consistency.
Replaced instances of "USWDS" with "Design System" for consistency and 18f compliance.
Revised "lead" text for consistent capitalization and punctuation. Removed out-of-date code box (which noted the wrong version of node). For consistency and 18f compliance, updated "USWDS" to "Design System" except when the term is used to describe a package called "USWDS."
Revised "lead" text for consistency. For consistency and 18f compliance, revised "USWDS" to "Design System" except when the term is used in reference to the package called "USWDS." Per usability testing, moved note from step 1 to the intro. Per usability testing, removed distracting links from the intro text.
Replaced uswds-gulp instructions with uswds-compile instructions
Updated "lead" text for consistency. Replaced gulp with compile
Contributor
Author
|
@mejiaj , Thanks for your help with these updates. Please read through phases 2 and 3 carefully to make sure I didn't delete or forget to add something important. |
…ates_uswds-compile
amyleadem
self-requested a review
February 17, 2022 15:27
amyleadem
reviewed
Feb 17, 2022
revised "look read" to "look like."
Contributor
|
@mejiaj Can I get your eyes on phase 2 and 3 to confirm content? A couple thoughts on phase 2:
|
mejiaj
reviewed
Feb 18, 2022
mejiaj
suggested changes
Feb 18, 2022
mejiaj
reviewed
Mar 9, 2022
mejiaj
reviewed
Mar 9, 2022
Contributor
|
Requires #1469 to be merged to fix build issues. |
mejiaj
approved these changes
Mar 9, 2022
mejiaj
left a comment
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Good choice to replace uswds-gulp with compile. I've made a few changes, mainly updating the old path references. Also as added some suggestions via comments.
Added a comma.
Moved note and deleted "below" for inclusive/accessible language.
amyleadem
reviewed
Mar 9, 2022
amyleadem
reviewed
Mar 9, 2022
Contributor
|
I have updated the Phase 2 side navigation and set the paths table to be scrollable. It's looking good! |
amyleadem
approved these changes
Mar 10, 2022
amyleadem
left a comment
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
All tests should be passing now. Looks good!
mejiaj
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated uswds-gulp info with uswds-compile guidance
Preview
Getting started for devs →