Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Form Component Markdown: Switched package name from usa-form-controls to form-controls #1497

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

mahoneycm
Copy link
Contributor

Description

Resolves #1468

Switches all @include usa-form-controls to @include form-controls. This affects the following component pages:

  • Combo-box
  • Date-input
  • Date-picker
  • Date-range-picker
  • file-input
  • Input-prefix-suffix
  • Radio-buttons
  • Text-input

Additional information

Before
image

After
image

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mahoneycm mahoneycm requested a review from mejiaj March 31, 2022 19:00
Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll just have to change them back in 3.0, but it's worth getting it right

@thisisdano thisisdano merged commit f6cf51b into main Apr 13, 2022
@thisisdano thisisdano deleted the cm-form-control-package-name branch April 13, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: incorrect package name for form controls
2 participants