Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Implementation Page: Added USWDS for Rails #1508

Merged
merged 5 commits into from
Jul 6, 2022

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Apr 4, 2022

Preview

Implementations →

Description

Resolves #1499

Adds Damian Burke's (Talaria Software) Implementation of USWDS using Rails to the Implementations page

Additional information

I placed it at the beginning but we can move it elsewhere if need be!

image

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't know how we normally order these, but I like the idea of placing the newest in the top.

@mahoneycm mahoneycm requested a review from amyleadem June 7, 2022 20:15
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

These are ordered alphabetically by Distribution let's stick to that convention. Could you update the order?

@amyleadem amyleadem requested a review from mejiaj June 23, 2022 18:35
@amyleadem
Copy link
Contributor

@mejiaj I have pulled in main and looks good to me. Will you take another look?

@amyleadem amyleadem merged commit a8dc4d1 into main Jul 6, 2022
@amyleadem amyleadem deleted the cm-implementation-component branch July 6, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rails Implementation
3 participants