Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Button: add instructions for type attribute #1608

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented May 18, 2022

Description

Closes #1609

Update button component page to include guidance on button type attribute.

This is part of the resolution of issue uswds/uswds#3563. Related PR: uswds/uswds#4695

Preview link: Button component page

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@amyleadem amyleadem changed the title USWDS-Site: Buttons: add instructions for type attribute USWDS-Site: Button: add instructions for type attribute May 18, 2022
@amyleadem amyleadem marked this pull request as ready for review May 18, 2022 16:07
Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto!

@thisisdano thisisdano merged commit db5f1a6 into main Jun 3, 2022
@thisisdano thisisdano deleted the al-button-type branch June 3, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add guidance for button type attribute
3 participants