Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Getting started: update notes on phase 2 and 3 #1667

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jun 17, 2022

Description

Adds additional notes to Phase 2 and 3 of Getting Started for Devs. Closes #1615 #1616.

Additional information

Phase two - preview →
Added examples for init and verification - 0a8cebe

image

Phase three - preview →
Changed filename for theme settings - ae5fb53

image


Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

- Use `init` note from USWDS/USWDS-Compile README.md (only run once)
- Add confirmation message from successful `compileSass` task
`_theme-settings.scss → _uswds-theme.scss`
@mejiaj mejiaj linked an issue Jun 17, 2022 that may be closed by this pull request
@mejiaj mejiaj requested a review from amyleadem June 17, 2022 16:10
@mejiaj mejiaj marked this pull request as ready for review June 17, 2022 16:11
@thisisdano thisisdano merged commit a03df95 into main Jun 17, 2022
@thisisdano thisisdano deleted the jm-update-getting-started-devs branch June 17, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation with regard to npx gulp init [Docs] - Improvements to Getting started for Devs
2 participants