Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Screen Reader instructions to Date Picker guidance #1695

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

brunerae
Copy link
Contributor

@brunerae brunerae commented Jul 1, 2022

Preview link

Date picker accessibility guidance

Description

Per comments in uswds/uswds#4271, screen reader instructions are skippable. We are now including them in the Accessibility section of guidance. Closes #1636

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@brunerae brunerae changed the title Adding Screen Reader instructions Adding Screen Reader instructions to Date Picker guidance Jul 1, 2022
Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I removed the brackets since after discussing with Ashley it seemed like we don't want them to display within the text.

@brunerae brunerae requested review from thisisdano and removed request for mejiaj and amyleadem July 5, 2022 15:55
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion to improve clarity since this is additional information, not an added feature.

Co-authored-by: James Mejia <james.mejia@gsa.gov>
@brunerae brunerae requested a review from mejiaj July 13, 2022 17:01
Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mejiaj! I want to introduce a bit more parallel structure to the list of instructions. So it would look like:

  • Days: left and right arrow keys
    • Weeks: up and down arrow keys
    • Months: use page up and page down
    • Years: use shift + page up and shift + page down
    • Beginning/End of week: use home and end keys

@amyleadem
Copy link
Contributor

Looks good!
I wonder if we should add instructions for those using Mac keyboards (at least smaller ones without page up, page down, home, etc keys), because it does require some translation to get this to work on my laptop.

Translation for Mac:
Months: fn + up arrow, fn + down arrow
Years: shift + fn + up arrow, shift + fn + down arrow
Beginning/End of week: fn + left arrow, fn + right arrow

@thisisdano thisisdano added this to the uswds 3.4.0 milestone Mar 7, 2023
@thisisdano thisisdano dismissed bonnieAcameron’s stale review March 8, 2023 01:03

Requested changes addressed

@thisisdano thisisdano changed the base branch from main to release-3.4.0 March 8, 2023 01:04
@thisisdano thisisdano merged commit aa51bac into release-3.4.0 Mar 8, 2023
@thisisdano thisisdano deleted the datepicker-a11y-instructions branch March 8, 2023 01:04
@thisisdano thisisdano mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info for skipping instructions for date range picker component to component page
5 participants