-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Screen Reader instructions to Date Picker guidance #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I removed the brackets since after discussing with Ashley it seemed like we don't want them to display within the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion to improve clarity since this is additional information, not an added feature.
Co-authored-by: James Mejia <james.mejia@gsa.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mejiaj! I want to introduce a bit more parallel structure to the list of instructions. So it would look like:
- Days: left and right arrow keys
- Weeks: up and down arrow keys
- Months: use page up and page down
- Years: use shift + page up and shift + page down
- Beginning/End of week: use home and end keys
…icker-a11y-instructions
|
Looks good! Translation for Mac: |
Preview link
Date picker accessibility guidance
Description
Per comments in uswds/uswds#4271, screen reader instructions are skippable. We are now including them in the
Accessibilitysection of guidance. Closes #1636Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.