Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site- accordion: Update multiselectable docs #1718

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jul 20, 2022

Summary

Update accordion documentation to use the correct multi-select attribute.

Our current accordion documentation tells users to add the aria-multiselectable="true" attribute to trigger a multi-select accordion group, but the attribute is actually data-allow-multiple.

Correcting this will make sure that users are able to successfully trigger the multi-select variant, while also preventing accessibility errors.

Related issue

Closes uswds/uswds#4865

Preview link

Preview link: Accordion component page

To confirm:

  1. Open the accordion twig file in USWDS
  2. Confirm that our templates use data-allow-multiple instead of aria-multiselectable="true" (In fact, there is no reference to aria-multiselectable in the USWDS code base.)

Before opening this PR, make sure you’ve done whichever of these applies to you:

  • Confirm that this code follows the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run git pull origin [base branch] to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch is develop).
  • Run npm test and confirm that all tests pass.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.

@amyleadem amyleadem marked this pull request as ready for review July 20, 2022 14:50
@amyleadem amyleadem requested a review from mejiaj July 20, 2022 14:50
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mejiaj mejiaj requested a review from thisisdano July 25, 2022 13:20
@thisisdano thisisdano merged commit 8798a67 into main Aug 1, 2022
@thisisdano thisisdano deleted the al-accordion-multi branch August 1, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS - Bug: Multiselectable Accordion not passing 508
3 participants