Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add $theme-footer-max-width variable #1719

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Docs: add $theme-footer-max-width variable #1719

merged 1 commit into from
Aug 29, 2022

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Jul 20, 2022

Description

This PR adds $theme-footer-max-width to the documentation. Closes #1696.

Additional information

Seen on pages


Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review July 20, 2022 16:17
@mejiaj mejiaj requested a review from amyleadem July 20, 2022 16:18
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mejiaj mejiaj requested a review from thisisdano July 26, 2022 18:25
@thisisdano thisisdano merged commit 77c3857 into main Aug 29, 2022
@thisisdano thisisdano deleted the jm-footer-docs branch August 29, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: Footer component missing '$theme-footer-max-width' setting documentation
3 participants