USWDS-Site: Update add-aspect documentation #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
commented
Jul 29, 2022
| @@ -32,8 +32,6 @@ variants: | |||
| description: In combination with `usa-card--flag`, sets the media element on the right. (Flag cards display media on the left by default.) | |||
| - variant: "`.usa-card__media--inset`" | |||
| description: Indents the media element so it doesn't extend to the edge of the card. | |||
| - variant: "`.usa-card__media--set-aspect`" | |||
There was a problem hiding this comment.
This variant is no longer needed. Users can directly apply add-aspect utility classes without needing to use this set-aspect class.
mejiaj
approved these changes
Aug 4, 2022
bonnieAcameron
approved these changes
Aug 5, 2022
thisisdano
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1702
Preview link
Preview link:
Summary
The
add-aspectutility was recently updated with expanded capabilities. This PR updates our documentation accurately represent the current state of add-aspect.Solution
After checking all references to add-aspect or "aspect ratio" on our site, I found only a need to update the card documentation. The current utility documentation was still accurate.
Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch isdevelop).npm testand confirm that all tests pass.