USWDS-Site: Resolve pa11y and html-proofer errors#1861
Merged
Conversation
mejiaj
approved these changes
Oct 31, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Thanks for those specific preview links, very helpful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved a couple of errors that appeared in
html-prooferand after the test upgrade to pa11y-ci v3.0 (This upgrade has not been included in this PR).Related issue
Closes #1860
Preview link
Preview links:
Problem statement
Tests to upgrade to pa11y-ci 3 revealed a new valid aria error:

html-proofer returned the error:
Solution
aria-describedbyto the appropriate relatedid.Testing and review
Confirm that the updated items continue to work as expected and that tests complete without error.