Skip to content

USWDS-Site: Resolve pa11y and html-proofer errors#1861

Merged
mejiaj merged 5 commits into
mainfrom
al-fix-pa11y3-errors
Oct 31, 2022
Merged

USWDS-Site: Resolve pa11y and html-proofer errors#1861
mejiaj merged 5 commits into
mainfrom
al-fix-pa11y3-errors

Conversation

@amyleadem

@amyleadem amyleadem commented Oct 27, 2022

Copy link
Copy Markdown
Contributor

Summary

Resolved a couple of errors that appeared in html-proofer and after the test upgrade to pa11y-ci v3.0 (This upgrade has not been included in this PR).

Related issue

Closes #1860

Preview link

Preview links:

Problem statement

Tests to upgrade to pa11y-ci 3 revealed a new valid aria error:
image

html-proofer returned the error:

For the Links > External check, the following failures were found:
* At ./_site/about/whats-new/index.html:2440:
 External link https://github.com/uswds/uswds-assets/issues/new failed (status code 404)
HTML-Proofer found 1 failure!

Solution

Testing and review

Confirm that the updated items continue to work as expected and that tests complete without error.

@amyleadem amyleadem changed the title USWDS-Site: Resolve pa11y 3 errors USWDS-Site: Resolve test errors Oct 28, 2022
@amyleadem amyleadem changed the title USWDS-Site: Resolve test errors USWDS-Site: Resolve pa11y and html-proofer errors Oct 28, 2022
@amyleadem amyleadem marked this pull request as ready for review October 31, 2022 14:27
@amyleadem amyleadem requested review from mahoneycm and mejiaj October 31, 2022 14:34

@mejiaj mejiaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those specific preview links, very helpful!

@mejiaj mejiaj merged commit 52b9caf into main Oct 31, 2022
@mejiaj mejiaj deleted the al-fix-pa11y3-errors branch October 31, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USWDS-Site: Resolve pa11y 3 and html-proofer errors

2 participants