Update to USWDS 3.3.0 / Patterns / Report #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not necessary in a navigation element
- Remove mobile from when not to use, since we don't consider that universal guidance. Teams should not use our component on mobile, but a mobile in-page nav is not impossible
Removing all the intersection observer details, since these options are not available to the implementor. It's useful info, but there's nothing for teams to do with it
…ers to tab to in-page nav before main content
The original 3.0 release note was updated. Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Based on PR comment #1871 (comment)
From suggestion in PR comment #1871 (comment)
Base on PR comment #1871 (comment). Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
…:uswds/uswds-site into mm-inclusive-patterns-in-page-navigation
Changed example for ethnicity
Update in-page nav with new properties
IDP component alert and combobox content updates
|
Links to USWDS 3.3.0 will fail until the release is published |
|
In a perfect world, on the Name form template the
|
jonadecker
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
I think it looks really good @thisisdano . I would love to see the Name form template preferred name match the pattern's preferred name hint text but it's not a deal breaker.
amyleadem
reviewed
Nov 14, 2022
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a number of updates to the design system:
Preview →