-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Header: Add variants table to guidance page #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this, @mahoneycm! Overall it looks good, I just added a couple suggestions for small tweaks in the changelog.
- Confirmed listed variants match those found in USWDS
- Confirmed the empty implementation sections have been removed
- Proofed for grammar and spelling
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
|
@mejiaj Bumping for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just flagging that we should update the changelog date before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Confirming:
- Variants table exists and is accurate.
- Empty sections are gone.
- Changelog entry exists.
@mahoneycm would you be able to briefly look into:
- A visual regression with touchpoints. If confirmed, can you create an issue if there isn't one already?
- Updating changelog date to today, so we can get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've pulled in latest from main branch.

Summary
Added header variants table to guidance page. This change also removes empty "Using the header" section.
Related issue
Closes #1976
Preview link
Preview link:
Header variants →
Header changelog →
Problem statement
The Header guidance page was missing a variants table that can be found in other component guidance pages. There were also empty implementation sections due to each component containing variants in its frontmatter, which were not displayed in the sections.
Solution
Move the
variantsout of the individual header variants front matter and include it in the base header guidance markdown page.Testing and review
Screenshots
Empty implementation section
There's an empty Using the... section for each variant

As seen on live site →
New variants table
Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch ismain).npm testand confirm that all tests pass.