USWDS-Site - Table: Restore standard table and striped table component previews #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Thanks for fixing this! Confirming it matches what's on wayback machine.
mejiaj
reviewed
Jun 15, 2023
| @@ -4,6 +4,13 @@ type: component | |||
| changelogURL: | |||
|
|
|||
| items: | |||
| - date: NNNN-NN-NN | |||
There was a problem hiding this comment.
Flagging this for change before merge.
mejiaj
reviewed
Jun 15, 2023
mejiaj
reviewed
Jun 15, 2023
amyleadem
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Thanks for finding and fixing this so quickly, @mahoneycm! Added a couple of small effort fixes for your review.
- Confirmed that all USWDS table variants are represented in uswds-site
- Confirmed that the variants and order match what is found in the wayback machine
- Confirmed that component preview and component code for standard and striped variants match what is found in Storybook
- Confirmed presentation in sidenav
- Found a typo that prevented the link text from appearing. Added a suggestion below.
- Proofed changlog entry for accuracy and typos.
- Added some small notes below.
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
|
@mahoneycm I added a couple of responses to my earlier comments. I am seeing that a couple items didn't get committed. Let me know if you have questions! |
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
|
@amyleadem sorry about that! Changes are committed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restore standard table and striped table component previews to guidance page
Related issue
Closes #2140
Preview link
Preview link:
Table →
Problem statement
The Table guidance page was missing the standard and striped component previews and code blocks
Solution
Create standard and striped variant markdown files and component code
includefile.Testing and review
Note: Both standard and striped variants don't appear to ever have had a lead sentence. Left blank for now.
Screenshot
Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch ismain).npm testand confirm that all tests pass.