Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Remove broken reference link on research page #2185

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jul 13, 2023

Summary

Removed broken link from research page

Related issue

Closes #2184

Preview link

Preview link: Research page

Problem statement

This broken link is causing build errors on uswds-site: http://www.uxbooth.com/articles/an-analytics-first-approach-to-ux-part-1/

Solution

Removed the broken link per the recommendation from @jaclinec.

Possible future enhancements

  • Review the content on the research page to make sure it is up-to-date and accurate.
  • Consider finding a suitable replacement link for the reference section

Note
I've opened #2188 to review the content on the research page and consider a replacement this removed link.

Testing and review

  • Confirm that the link is still broken
  • Confirm that this update passes tests
  • Confirm the changelog is accurate and free from error

@amyleadem amyleadem marked this pull request as ready for review July 14, 2023 15:21
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Should we add a note to check the removed link in the future and add it back in the event that it's working again?

Tested:

  • Link was removed
  • Changelog item added
  • HTML Proofer gives all links a pass

@@ -23,10 +28,9 @@ Web Design System. We will use this information to identify future
improvements to the design patterns. You can use these metrics to help justify
the adoption and continued use of USWDS.

#### References
#### Reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🥇

@amyleadem
Copy link
Contributor Author

Thanks @mahoneycm. I've opened #2188 to review the content on the research page with a note about considering a replacement this removed link.

@amyleadem amyleadem merged commit fdddcdd into main Jul 14, 2023
@amyleadem amyleadem deleted the al-500-error branch July 17, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site: Fix html-proofer errors
4 participants