-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Card: Add header exdent to variant table #2228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Added a couple of little suggestions for the changelog.
Also, wondering if the variants list should be alphabetized. It doesn't seem to be the standard on the site but it would make my little organization heart happy. No action needed here, just flagging it.
I checked the following:
-
usa-card__header--exdentvariant present in table - Class name matches actual class in the design system
- Variant guidance is appropriate and understandable
- Variant is proper place on table
- Approved changelog
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
|
@amyleadem I agree about the alphabetization. I started adding it to the table with that in mind, but noticed the exdent values were put together and the other values were not alphabetized. If we think it's a good idea to alphebetize, I'm happy to do so! Maybe we could come up with an organization pattern like organized by variant then alphabetized to get the best of both worlds? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, what do you think about alphabetizing just the exdent variants items so that it goes like: body--exdent, footer-exdent, etc?
It might be worth discussing opening an issue to alphabetize variants across components since it doesn't seem very consistent.
…r-exdent-guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Summary
Adds missing
header--exdentclass to card variants table.Related issue
Closes #2209
Preview link
Card variants →
Problem statement
The card variants table was missing the
header--exdentvariant despite the design system offering the class and styles.Solution
Add
usa-card__header--exdentvariant to table.Additional Context
Exdent classes were added in uswds/uswds#3437 (May 2020)
header--exdentin the New Variants section, but it was not listed in the Variant Options tableGuidance was updated in Add card component documentation #913 and specifically commit 877543c (May 2020)
It looks to me like the header exdent was unintentionally left out since the class was added.
Testing and review
header--exdentvariant is listedTesting checklist
usa-card__header--exdentvariant present in table