-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Icon: Add note about icon color contrast #2258
Conversation
|
Approved as-is. However, I suggest changing the link from a generic W3C link text to instead read: 1.4.11: Non-text Contrast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only improvement would be to clarify exactly which WCAG success criteria we're referring to in the link text. The link itself is good and points the user to a useful page. It's not a requirement, however, just a suggestion.
|
@amycole501 Good point! I updated the link text to reflect the title of the article. Let me know if you want any changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 👍
…on-contrast-note
…on-contrast-note
|
@sarah-sch would you be able to review & approve? We can merge after. |
…on-contrast-note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing, @amyleadem! Katie and I are suggesting some tweaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for sufficient color contrast. Verify that the icon has a minimum contrast ratio of 3:1 against its background. See [WCAG 2.1 Techniques: Ensuring that a contrast ratio of 3:1 is provided
@amyleadem - looked at this with @finekatie and we are suggesting some tweaks to maintain USWDS's conversational, approachable style: Check for good color contrast. Make sure that the icon has a minimum contrast ratio of 3:1 against its background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarah-sch @finekatie
Good improvement! I've updated the copy in c634d58. Let me know if you want any changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good--thanks!
Summary
Added a note about checking icon color contrast.
Related issue
Closes #2224
Preview link
Icon component page
Testing and review
Confirm that the copy makes sense, conveys what we want it to, and is free from spelling and grammatical error.