Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Fix component pages from audit (Phase 3) #2291

Merged
merged 12 commits into from Nov 20, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Sep 28, 2023

Summary

Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)

Note

For easier reviews, this PR includes only the simple changes. The changes that are included in this PR are marked in green on the spreadsheet. Items that need more discussion or their own issues are marked in yellow. Items marked in red will not be pursued.

Warning

Before merge, we should update all NNNN-NN-NN changelog dates.

Related issue

Closes #2163

Preview link

@amyleadem amyleadem marked this pull request as ready for review October 6, 2023 22:28
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question about usa-input--[width] classes

Testing checklist

  • Radio
  • Site alert
  • Table
  • Tag
  • Text input

_components/text-input/text-input.md Show resolved Hide resolved
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! All green changes are accounted for and accurate 👍

Testing checklist

  • Radio
  • Site alert
  • Table
  • Tag
  • Text input

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added screenshots and preview links in relevant code files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyleadem amyleadem requested review from thisisdano and removed request for thisisdano November 20, 2023 16:09
@amyleadem amyleadem merged commit f191053 into main Nov 20, 2023
11 checks passed
@mejiaj mejiaj deleted the al-component-updates-phase-3 branch February 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Code audit: Fix inaccuracies in component pages (Phase 3)
3 participants