New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Fix component pages from audit (Phase 3) #2291
Conversation
- Also add periods to variants
…mponent-updates-phase-3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one question about usa-input--[width]
classes
Testing checklist
- Radio
- Site alert
- Table
- Tag
- Text input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! All green changes are accounted for and accurate 👍
Testing checklist
- Radio
- Site alert
- Table
- Tag
- Text input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added screenshots and preview links in relevant code files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_components/site-alert/site-alert.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_components/table/table.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_components/tag/tag.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…mponent-updates-phase-3
Summary
Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)
Note
For easier reviews, this PR includes only the simple changes. The changes that are included in this PR are marked in green on the spreadsheet. Items that need more discussion or their own issues are marked in yellow. Items marked in red will not be pursued.
Warning
Before merge, we should update all
NNNN-NN-NN
changelog dates.Related issue
Closes #2163
Preview link