Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Update research page content #2355

Merged
merged 13 commits into from
Nov 15, 2023
Merged

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Nov 14, 2023

Summary

Changed out the the content on the research page to match the updates in this document (Google docs 🔒).

Related issue

Closes #2354

Preview link

Preview link: Research page

Testing and review

  • Confirm that all content from the Google doc has been added to the page
  • Confirm that all links are present and work as expected
  • Confirm that the content makes sense and has no spelling or grammatical errors
  • Confirm that the content is styled appropriately

@amyleadem amyleadem marked this pull request as ready for review November 15, 2023 16:30
@jaclinec
Copy link
Contributor

Everything looks good, I only have a few small suggestions:

  • In the 'Research Methods' first paragraph, I recommend taking out "the" before 18F Methods.
  • In the 'research Ethics' section, there's a typo: "Learn more about cresearch ethics and privacy protocols..."

Also, I am wondering if we want to keep the links for specific research methods (user interviews, card sorting, usability testing) or if we should take them out since it looks inconsistent to have links for some and not all methods. Will defer to what @annepetersen and @thisisdano think on that.

Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in the Conversation tab.

@amyleadem
Copy link
Contributor Author

@jaclinec
cc: @annepetersen @thisisdano

I made your requested updates in 68018ee.

I also:

  • Added the new links to research methods found in the doc in 94a4a4b.
  • Standardized the width of the content styles in e64c152 (The list styles were extending wider than the paragraphs)

Please let me know if you need anything else!

@annepetersen
Copy link
Contributor

Approved from my end. @thisisdano?

Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one small change: let's delete the "Concept testing" bullet point in the research methods section.

Anne and I discussed it and agreed it kind of represents a broad category of testing approach rather than a specific method in itself.

@amyleadem
Copy link
Contributor Author

@jaclinec Removed the "concept testing" bullet in 82f4268.

Let me know if you need anything else!

Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all!

@thisisdano thisisdano merged commit c047e54 into main Nov 15, 2023
11 checks passed
@thisisdano thisisdano deleted the al-research-page-redo branch November 15, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish main research page
4 participants