Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Add known issues section to date picker page #2360

Merged
merged 5 commits into from
Nov 15, 2023
Merged

USWDS-Site: Add known issues section to date picker page #2360

merged 5 commits into from
Nov 15, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Nov 15, 2023 •
edited
Loading

Summary

Added a known issues section to the date picker component page.

Related PR

This is a partial implementation of the prototype found in #2326

Preview link

Preview link: Date picker page

Testing and review

  • Confirm a known issues section appears on the date picker page
  • Confirm the info alert is present at the top of the date picker page
  • Confirm that there is no known issues section or alert on other component pages
  • On known issues list items:
    • Confirm that the issue descriptions are accurate
    • Confirm that GitHub links work as expected
  • Confirm there are no spelling or grammar issues

@amyleadem amyleadem marked this pull request as ready for review November 15, 2023 22:24
thisisdano
thisisdano approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@thisisdano thisisdano merged commit d12404d into main Nov 15, 2023
8 checks passed
@thisisdano thisisdano deleted the al-add-known-issues branch November 15, 2023 23:49
@amyleadem amyleadem mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyleadem @thisisdano