-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Fix token pages from audit (Part 3) #2379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments about the theoretical variables for letterspacing and font-weight. Otherwise, lgtm!
- Removing because there is no theme setting for this
@mahoneycm Thanks for your suggested edits. This should be ready for your re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks for making those changes
@@ -2,6 +2,11 @@ title: Typesetting tokens | |||
type: token | |||
changelogURL: | |||
items: | |||
- date: NNNN-NN-NN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Need to update the changelog dates before merge
Merging over circle crashes |
Summary
Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)
Note
To keep PR reviews manageable, this PR updates only the typography tokens pages. All other token page updates will be addressed in other PRs.
Warning
We will need to update the changelog dates before merge.
Related issue
Related to #2042
Preview link
Preview link:
Solution
Update code according to the findings in code/developer content audit (Google Docs 🔒).
Please note that all items highlighted yellow in the spreadsheet will be investigated/discussed in the last phase of the component page fixes.
Testing and review