Skip to content

USWDS-Site: Fix token pages from audit (Part 3) - #2379

Merged
thisisdano merged 24 commits into
mainfrom
al-tokens-audit-3
May 15, 2024
Merged

thisisdano merged 24 commits into
mainfrom
al-tokens-audit-3

Conversation

@amyleadem

@amyleadem amyleadem commented Nov 28, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)

Note

To keep PR reviews manageable, this PR updates only the typography tokens pages. All other token page updates will be addressed in other PRs.

Warning

We will need to update the changelog dates before merge.

Related issue

Related to #2042

Preview link

Preview link:

Solution

Update code according to the findings in code/developer content audit (Google Docs 🔒).

Please note that all items highlighted yellow in the spreadsheet will be investigated/discussed in the last phase of the component page fixes.

Testing and review

  • Confirm that all updates are accurate and make sense
  • Confirm that all meaningful updates have a related changelog
    • "Meaningful" updates here mostly applied to adding or removing documentation about variants, dependencies, etc. Copy tweaks to add clarity were not considered meaningful, but a case could be made for them to be included.
  • Confirm grammar and spelling for all updates

@amyleadem
amyleadem marked this pull request as ready for review November 28, 2023 17:32
@amyleadem amyleadem linked an issue Nov 28, 2023 that may be closed by this pull request

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments about the theoretical variables for letterspacing and font-weight. Otherwise, lgtm!

@amyleadem amyleadem self-assigned this Dec 14, 2023
@amyleadem amyleadem added the Added during Sprint Historical record of work added during a sprint. Not required for current triage. label Apr 2, 2024
@amyleadem amyleadem removed the Added during Sprint Historical record of work added during a sprint. Not required for current triage. label Apr 8, 2024
@amyleadem
amyleadem requested a review from mahoneycm April 11, 2024 21:16
@amyleadem

Copy link
Copy Markdown
Contributor Author

@mahoneycm Thanks for your suggested edits. This should be ready for your re-review.

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for making those changes

@amyleadem
amyleadem requested a review from thisisdano April 15, 2024 14:39
type: token
changelogURL:
items:
- date: NNNN-NN-NN

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Need to update the changelog dates before merge

Comment thread _data/changelogs/tokens-type.yml Resolved
Comment thread _data/changelogs/tokens-type.yml Resolved
@thisisdano

Copy link
Copy Markdown
Contributor

Merging over circle crashes

@thisisdano
thisisdano merged commit 7fc2400 into main May 15, 2024
@thisisdano
thisisdano deleted the al-tokens-audit-3 branch May 15, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

USWDS-Site - Code audit: Fix inaccuracies in tokens pages

4 participants