Repository navigation
USWDS-Site: Fix token pages from audit (Part 3) - #2379
Merged
Merged
Conversation
added 11 commits
November 27, 2023 16:58
amyleadem
commented
Nov 28, 2023
amyleadem
commented
Nov 28, 2023
mahoneycm
reviewed
Nov 30, 2023
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
Left two comments about the theoretical variables for letterspacing and font-weight. Otherwise, lgtm!
mejiaj
approved these changes
Apr 5, 2024
added 7 commits
April 9, 2024 07:50
- Removing because there is no theme setting for this
Contributor
Author
|
@mahoneycm Thanks for your suggested edits. This should be ready for your re-review. |
mahoneycm
approved these changes
Apr 15, 2024
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
Lgtm! Thanks for making those changes
amyleadem
commented
Apr 26, 2024
| type: token | ||
| changelogURL: | ||
| items: | ||
| - date: NNNN-NN-NN |
Contributor
Author
There was a problem hiding this comment.
Important
Need to update the changelog dates before merge
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
approved these changes
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
thisisdano
reviewed
May 15, 2024
Contributor
|
Merging over circle crashes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)
Note
To keep PR reviews manageable, this PR updates only the typography tokens pages. All other token page updates will be addressed in other PRs.
Warning
We will need to update the changelog dates before merge.
Related issue
Related to #2042
Preview link
Preview link:
Solution
Update code according to the findings in code/developer content audit (Google Docs 🔒).
Please note that all items highlighted yellow in the spreadsheet will be investigated/discussed in the last phase of the component page fixes.
Testing and review