Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Fix token pages from audit (Part 3) #2379

Merged
merged 24 commits into from
May 15, 2024
Merged

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Nov 28, 2023

Summary

Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)

Note

To keep PR reviews manageable, this PR updates only the typography tokens pages. All other token page updates will be addressed in other PRs.

Warning

We will need to update the changelog dates before merge.

Related issue

Related to #2042

Preview link

Preview link:

Solution

Update code according to the findings in code/developer content audit (Google Docs 🔒).

Please note that all items highlighted yellow in the spreadsheet will be investigated/discussed in the last phase of the component page fixes.

Testing and review

  • Confirm that all updates are accurate and make sense
  • Confirm that all meaningful updates have a related changelog
    • "Meaningful" updates here mostly applied to adding or removing documentation about variants, dependencies, etc. Copy tweaks to add clarity were not considered meaningful, but a case could be made for them to be included.
  • Confirm grammar and spelling for all updates

@amyleadem amyleadem marked this pull request as ready for review November 28, 2023 17:32
@amyleadem amyleadem linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments about the theoretical variables for letterspacing and font-weight. Otherwise, lgtm!

pages/design-tokens/typesetting/font-weight.md Outdated Show resolved Hide resolved
pages/design-tokens/typesetting/letterspacing.md Outdated Show resolved Hide resolved
@amyleadem
Copy link
Contributor Author

@mahoneycm Thanks for your suggested edits. This should be ready for your re-review.

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for making those changes

@@ -2,6 +2,11 @@ title: Typesetting tokens
type: token
changelogURL:
items:
- date: NNNN-NN-NN
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Need to update the changelog dates before merge

@thisisdano
Copy link
Member

Merging over circle crashes

@thisisdano thisisdano merged commit 7fc2400 into main May 15, 2024
8 of 11 checks passed
@thisisdano thisisdano deleted the al-tokens-audit-3 branch May 15, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Code audit: Fix inaccuracies in tokens pages
4 participants