Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Fix typos in compile instructions #2401

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Dec 18, 2023

Summary

  • Fixed typos and outdated references on the Phase 2: Compile and Packages pages.
  • Added documentation for projectIcons and projectIconsOnly settings for uswds-compile

Important

We should update changelog dates before merge

Related issue

Closes #2288

Preview link

Problem statement

There are a few outdated references and typos in our documentation. We should confirm that our uswds-compile settings documentation is up-to-date and accurate.

Testing and review

  1. Confirm that the information in the settings table matches the uswds-compile readme.
  2. Confirm that all issues outlined in issue USWDS-Site - Bug: Minor typos in Getting Started/Phase 2 and Components/Packages #2288 have been fixed.

@amyleadem amyleadem marked this pull request as ready for review December 18, 2023 18:48
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -2,6 +2,16 @@ title: "Phase 2: Compile"
type: documentation
changelogURL:
items:
- date: NNNN-NN-NN
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We should update changelog dates before merge

@thisisdano thisisdano merged commit 3e60cdf into main Apr 26, 2024
2 of 6 checks passed
@thisisdano thisisdano deleted the al-compile-typos branch April 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: Minor typos in Getting Started/Phase 2 and Components/Packages
4 participants