From 6030468b1ba310b956cff87d1c6c54ee285f03b8 Mon Sep 17 00:00:00 2001 From: James Mejia Date: Tue, 20 Feb 2024 16:08:10 -0600 Subject: [PATCH 1/4] Create changelog entry for uswds/uswds#5233 --- _data/changelogs/component-text-input.yml | 15 +++++++++++++++ _data/changelogs/component-validation.yml | 14 ++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/_data/changelogs/component-text-input.yml b/_data/changelogs/component-text-input.yml index ac6449d9d9..8caf3f90ab 100644 --- a/_data/changelogs/component-text-input.yml +++ b/_data/changelogs/component-text-input.yml @@ -5,6 +5,21 @@ type: component changelogURL: items: + - date: NNNN-NN-NN + summary: Textarea supports validation. + summaryAdditional: + isBreaking: false + affectsAccessibility: + affectsAssets: + affectsContent: + affectsGuidance: + affectsJavascript: true + affectsMarkup: true + affectsSettings: true + affectsStyles: + githubPr: 5233 + githubRepo: uswds + versionUswds: 3.8.0 - date: 2023-11-16 summary: Updated the listed values for `.usa-input--[width]`. affectsGuidance: true diff --git a/_data/changelogs/component-validation.yml b/_data/changelogs/component-validation.yml index a573a2fda3..cf85e2f3c1 100644 --- a/_data/changelogs/component-validation.yml +++ b/_data/changelogs/component-validation.yml @@ -2,6 +2,20 @@ title: Validation type: component changelogURL: items: + - date: NNNN-NN-NN + summary: Validation support added to textarea. + isBreaking: false + affectsAccessibility: false + affectsAssets: + affectsContent: + affectsGuidance: + affectsJavascript: true + affectsMarkup: true + affectsSettings: true + affectsStyles: + githubPr: 5233 + githubRepo: uswds + versionUswds: 3.8.0 - date: 2022-12-21 summary: Clarified implementation guidance and removed the `#` from the example `data-validation-element` value. summaryAdditional: From 8ed10eb005acce5e281a976718f322fff75d8436 Mon Sep 17 00:00:00 2001 From: James Mejia Date: Tue, 20 Feb 2024 16:08:26 -0600 Subject: [PATCH 2/4] Remove extra period from text input guidance --- _components/text-input/guidance/usability.md | 1 - 1 file changed, 1 deletion(-) diff --git a/_components/text-input/guidance/usability.md b/_components/text-input/guidance/usability.md index d5965799d9..f891135884 100644 --- a/_components/text-input/guidance/usability.md +++ b/_components/text-input/guidance/usability.md @@ -2,4 +2,3 @@ - **Consider the mobile context.** Text inputs are among the easiest type of input for desktop users but are more difficult for mobile users. - **Wait to validate.** Only show error validation messages or stylings after a user has interacted with a particular field. - **Avoid placeholder text.** Avoid using placeholder text that appears within a text field before a user starts typing. If placeholder text is no longer visible after a user clicks into the field, users will no longer have that text available when they need to review their entries. (People who have cognitive or visual disabilities have additional problems with placeholder text.) -. \ No newline at end of file From ec7d03ce690a3c706803a66a1f847d72366dca64 Mon Sep 17 00:00:00 2001 From: Amy Leadem <93996430+amyleadem@users.noreply.github.com> Date: Thu, 29 Feb 2024 10:23:44 -0700 Subject: [PATCH 3/4] Update sentence structure for 5233 --- _data/changelogs/component-text-input.yml | 2 +- _data/changelogs/component-validation.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/_data/changelogs/component-text-input.yml b/_data/changelogs/component-text-input.yml index 8caf3f90ab..877a244d5f 100644 --- a/_data/changelogs/component-text-input.yml +++ b/_data/changelogs/component-text-input.yml @@ -6,7 +6,7 @@ changelogURL: items: - date: NNNN-NN-NN - summary: Textarea supports validation. + summary: Added `textarea` support to the validation component. summaryAdditional: isBreaking: false affectsAccessibility: diff --git a/_data/changelogs/component-validation.yml b/_data/changelogs/component-validation.yml index cf85e2f3c1..ff1200f549 100644 --- a/_data/changelogs/component-validation.yml +++ b/_data/changelogs/component-validation.yml @@ -3,7 +3,7 @@ type: component changelogURL: items: - date: NNNN-NN-NN - summary: Validation support added to textarea. + summary: Added `textarea` support to the validation component. isBreaking: false affectsAccessibility: false affectsAssets: From f32e5fa16ae912415cdac43708085f3a33282c57 Mon Sep 17 00:00:00 2001 From: amyleadem Date: Fri, 1 Mar 2024 14:59:55 -0700 Subject: [PATCH 4/4] Remove settings from 5233 --- _data/changelogs/component-text-input.yml | 7 +------ _data/changelogs/component-validation.yml | 7 +------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/_data/changelogs/component-text-input.yml b/_data/changelogs/component-text-input.yml index 877a244d5f..2b2b17c014 100644 --- a/_data/changelogs/component-text-input.yml +++ b/_data/changelogs/component-text-input.yml @@ -6,16 +6,11 @@ changelogURL: items: - date: NNNN-NN-NN - summary: Added `textarea` support to the validation component. + summary: Added `textarea` support to the validation component. summaryAdditional: isBreaking: false - affectsAccessibility: - affectsAssets: - affectsContent: - affectsGuidance: affectsJavascript: true affectsMarkup: true - affectsSettings: true affectsStyles: githubPr: 5233 githubRepo: uswds diff --git a/_data/changelogs/component-validation.yml b/_data/changelogs/component-validation.yml index ff1200f549..f4449886fa 100644 --- a/_data/changelogs/component-validation.yml +++ b/_data/changelogs/component-validation.yml @@ -3,16 +3,11 @@ type: component changelogURL: items: - date: NNNN-NN-NN - summary: Added `textarea` support to the validation component. + summary: Added `textarea` support to the validation component. isBreaking: false affectsAccessibility: false - affectsAssets: - affectsContent: - affectsGuidance: affectsJavascript: true affectsMarkup: true - affectsSettings: true - affectsStyles: githubPr: 5233 githubRepo: uswds versionUswds: 3.8.0