-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add icon accessibility tests page #2518
Conversation
|
Adding @finekatie and me as reviewers on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amycole501 @alex-hull @finekatie @sarah-sch
I've added some comments about the content for these checklist items. Happy to meet up to discuss if that is simpler!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
I did a first pass at the summary elements here because I didn't see them in the spreadsheet. I've also added these summaries to Column L in the spreadsheet.
If a test for the same WCAG criterion was already added to an existing accessibility tests page, I tried to match the language and sentence structure whenever possible. For example, "Color is not the only method used to convey icon information." here matches the structure of "Color is not the only method used to indicate links." on the link accessibility tests page.
Please feel free to provide suggestions for alternative summaries!
| - summary: Icons meet color contrast requirements. | ||
| summary_additional: | | ||
| When you view the icon on a webpage | ||
| and use ANDI or color contrast analyzer to look at the hex colors, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
I added this line about ANDI/color analyzer because we added it on the button tests page. Let me know if I should remove it.
|
@sarah-sch @finekatie @amycole501 @alex-hull |
|
@amyleadem Did we plan to not add the little blurb about why these items are marked as conditional? I feel like there will be questions related to that, so we would maybe need to add it in at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with my in-line suggestions, please change the text above the table (at top of page) to read as follows: "The USWDS team did five tests based on WCAG 2.1 AA success criteria." (Spell out five instead of using a numeral because it's less than 10.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Sarah's comments; the page looks good to me.
|
@sarah-sch Your requested updates should now be live. Let me know if you need any more changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to publish as an MVP after fed review
|
@thisisdano @annepetersen This is ready for your review. FYI - I am able to get pa11y tests to pass locally, but they are still crashing here. Going to keep trying to get them to pass here 🏄 |
|
Merging over crashing pa11y test |
Summary
Added icon accessibility test page.
Note
These tests for this component are all marked as conditional. This is because there are different methods for including an icon on a page, each with different levels of accessibility. This variability made the icon tests feel different from the other components in the system, and the team felt like there should be extra emphasis on testing icon implementation in each project.
The team drafted a sample explanation that we can include on the page, if desired. It is not included on the page yet, but we can work to include something like this now or as a quick follow-on:
Icons can be decorative or functional. How you check an icon for compliance depends on how it's used. This is why the the checks below are marked as conditional. Our icon library is accessible to 2.1 AA standards. Follow the checks below to determine if your use of an icon passes each success criteria.
Important
We need to confirm the changelog dates before merge.
Resources
Related issue
Closes #2535
Preview link
Testing and review