-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usability.md #2563
Update usability.md #2563
Conversation
Updating alert guidance to explain that USWDS is working on a solution that will help developers make alert dismissible.
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
…-site into ss-alert-page-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarah-sch This looks good! I think this change warrants a changelog entry, so I drafted one in _data/changelogs/component-alert.yml and pushed it up. Feel free to edit as needed!
|
@mahoneycm - I fixed that link. Thanks! Can you approve if it looks good? |
correcting spelling of "dismissible"
correcting spelling of "dismissible"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks, @amyleadem! I fixed the spelling of "dismissible" in the changelog and in the new guidance, and I think it's ready for FFR now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@annepetersen ready for override merge, only outstanding issues are the pa11y timeout failures. |
Updating alert guidance to explain that USWDS is working on a solution that will help developers make alert dismissible.
Summary
Updating usability guidance on Alert page to explain that USWDS team is working on a solution to make Alerts dismissible.
Related issue
Closes #2425
Preview link
Preview link: Preview Alert page here.
Problem statement
Currently, USWDS guidance recommends making the Alert dismissible, but we don't provide an easy way for devs to implement a dismissible alert. This causes confusion for users.
Solution
This PR updates our guidance to explain that we are working on a solution. We're also providing a link so that the community can follow our progress.
Major changes
NA
Testing and review
Share recommended methods for reviewing this change.