Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usability.md #2563

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Update usability.md #2563

merged 7 commits into from
Mar 29, 2024

Conversation

sarah-sch
Copy link
Contributor

@sarah-sch sarah-sch commented Mar 27, 2024

Updating alert guidance to explain that USWDS is working on a solution that will help developers make alert dismissible.

Summary

Updating usability guidance on Alert page to explain that USWDS team is working on a solution to make Alerts dismissible.

Related issue

Closes #2425

Preview link

Preview link: Preview Alert page here.

Problem statement

Currently, USWDS guidance recommends making the Alert dismissible, but we don't provide an easy way for devs to implement a dismissible alert. This causes confusion for users.

Solution

This PR updates our guidance to explain that we are working on a solution. We're also providing a link so that the community can follow our progress.

Major changes

NA

Testing and review

Share recommended methods for reviewing this change.

Updating alert guidance to explain that USWDS is working on a solution that will help developers make alert dismissible.
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah-sch This looks good! I think this change warrants a changelog entry, so I drafted one in _data/changelogs/component-alert.yml and pushed it up. Feel free to edit as needed!

@sarah-sch
Copy link
Contributor Author

sarah-sch commented Mar 27, 2024

@mahoneycm - I fixed that link. Thanks! Can you approve if it looks good?

correcting spelling of "dismissible"
correcting spelling of "dismissible"
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarah-sch
Copy link
Contributor Author

sarah-sch commented Mar 27, 2024

@sarah-sch This looks good! I think this change warrants a changelog entry, so I drafted one in _data/changelogs/component-alert.yml and pushed it up. Feel free to edit as needed!

Thanks, @amyleadem! I fixed the spelling of "dismissible" in the changelog and in the new guidance, and I think it's ready for FFR now.

@sarah-sch sarah-sch requested review from annepetersen and removed request for finekatie March 27, 2024 16:57
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mejiaj
Copy link
Contributor

mejiaj commented Mar 29, 2024

@annepetersen ready for override merge, only outstanding issues are the pa11y timeout failures.

@annepetersen annepetersen merged commit ade2de2 into main Mar 29, 2024
8 of 11 checks passed
@annepetersen annepetersen deleted the ss-alert-page-update branch March 29, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: Remove mention of Alert dismissability
6 participants