USWDS-Site Pattern pages: Fix broken federalist links found in language selector section. #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Thanks for jumping on this so quickly @mahoneycm. I added a comment about using federalist_base for these links. Let me know if you have questions!
amyleadem
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
This looks good! Thanks @mahoneycm.
Note
I went ahead and pushed up a change to the changelogs that replaced affectsContent with affectsGuidance because the content tag is typically reserved for the content inside a component or pattern. Let me know if you have any questions!
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates cloud pages links to match new pattern. This resolves broken links found on language selector previews.
Important
We need to update changelog dates before merge
Related issue
Closes #2558
Preview link
Two languages →
Three or more languages →
Selected multilingual content →
Problem statement
There are broken links on the “Select a language” pattern pages. This was caused due to the cloud pages url pattern changing from
app.cloud.govtosites.pages.cloud.gov.Solution
Update links to match new pattern.
Testing and review
Note
These pages are being ignored by html-proofer at this time. This is being explored further in #2169.