Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add February 2024 monthly call #2576

Merged
merged 8 commits into from
Apr 26, 2024
Merged

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented Mar 28, 2024

Adding the February event, along with a description and related links, to the USWDS monthly call page.

Summary

This purpose of this PR is to update the monthly call page to include a video (and supplemental information) for the February 2024 monthly call. This update will keep the page relevant and timely.

Important

This PR is related to #2631 as we now have updates for March as well. This PR should be merged before that one.

Related issue

Closes #2551
Closes #2529

Preview link

Monthly calls page

Problem statement

The February 2024 event needs to be added to the USWDS monthly calls page.

Solution

This action will add the February 2024 event to the monthly call page so that the USWDS community can enjoy it!

Major changes

n/a

Testing and review

Please proof the new content and make sure it's formatted correctly.

Added February monthly call copy to the yml file. 
Needs review for line 7 = ID. Not sure how that is assigned.
Needs review for adding Q&A link. I put in the full link title and link, but that's different from how video and event link were added previously. We won't have video for at least another week.
@finekatie finekatie added the Affects: Content Relates to content label Mar 28, 2024
@finekatie
Copy link
Contributor Author

Added February monthly call copy to the yml file. Needs review for line 7 = ID. Not sure how that is assigned. Needs review for adding Q&A link. I put in the full link title and link, but that's different from how video and event link were added previously. We won't have video for at least another week.

@amyleadem
Copy link
Contributor

This afternoon I'll work on updating the code here to include the Q&A link and also remove the video preview if no ID is provided.

@finekatie
Copy link
Contributor Author

This afternoon I'll work on updating the code here to include the Q&A link and also remove the video preview if no ID is provided.

Oh does the id come from the video? We won't have that for at least another week.

@amyleadem
Copy link
Contributor

@finekatie @sarah-sch I've updated the code do hide the video for now and add the Q&A copy. Let me know if that looks good to you!

@finekatie
Copy link
Contributor Author

@finekatie @sarah-sch I've updated the code do hide the video for now and add the Q&A copy. Let me know if that looks good to you!

Looks good to me! Thank you, Amy!

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can add the video once it is ready.

Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Added ID for Feb call video
@finekatie
Copy link
Contributor Author

We got the link for the video today. I just added the id for it and committed.

@annepetersen
Copy link
Contributor

@thisisdano I've looked at this: could we publish it without your review?

@thisisdano
Copy link
Member

Note that I removed all the affectsGuidance keys in the changelogs, since this content isn't guidance

@finekatie finekatie removed the request for review from sarah-sch April 26, 2024 18:04
@finekatie
Copy link
Contributor Author

Hey @amyleadem , can you take a look at this? Dan approved, but it's failing checks.

@thisisdano thisisdano merged commit ca74718 into main Apr 26, 2024
8 of 11 checks passed
@thisisdano thisisdano deleted the kf-feb-24-mc-page-updates branch April 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Content Relates to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Enhancement: Add GitHub Q&As to monthly calls page Add Feb. video to USWDS monthly calls page
4 participants