-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - Accessibility tests: Publish Prose checklist page #2613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I had some questions and comments below. Let me know if you have an questions.
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page reads well, I didn't find any errors or issues. Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I confirmed the following:
- Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
- Confirm that the main component page links to the accessibility tests page in the side navigation.
- Check that accessibility tests page provides the correct counts for each test status type.
- Confirm the test checklist summaries and data are accurate.
- Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.
- Confirm the note in the accessibility guidance section of the main component page uses the correct component name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pages good, aside from changelog dates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating changelog dates...
|
Merging over pa11y crashes |
Summary
Created Prose accessibility checklist following the provided guidance (🔒)
Important
We should update the changelog dates before merge.
Note
We don't currently provide guidance on how to adjust text spacing. Until we do, we've opted to remove item
1.4.12from the site testing checklist and rely on1.4.4to cover this test.Additional information can be found in this comment thread
Related issue
Closes #2531
Preview link
Prose component page →
Prose accessibility checklist →
Major changes
Accessibility guidance section
I added a comment to the
usa-prose/guidance/accessibility.mdfile so that it doesn’t render asnulland it properly adds the testing alert.Is this a pattern we want to follow for pages without other accessibility guidance?
Testing and review
contentas it's test type. Confirm usinggeneralis appropriate here