USWDS-Site - Date range picker: Add date picker known issues to date range picker

[amyleadem]

Summary

• Added date picker known issues to the date range picker page
• Created the known_issues_key front matter variable so that we can share known issues across pages if needed.
• Cleaned up code to prevent duplication

Related issue

Closes #2580

Preview link

Date range picker page

Problem statement

The date range picker is affected by known issues listed on the date picker page. The date range picker page should pull in known issues from the date picker component.

Solution

Testing and review

1. Confirm that the date picker known issues appear on the date range picker page
2. Confirm that all links in the known issues section point to the expected location
3. Confirm that the known issues alert appears at the top of the date range picker page
4. Confirm no regressions on other pages with known issues (character count, combo box, date picker, file input, input mask, validation)
5. Confirm this code meets standards

[amyleadem]

Note

Edited the vars here to accomplish the following:

1. Accommodate the new known_issues_key in one spot
2. Have clearer names (issues -> known_issues)
3. Standardize implementation and remove duplicate code for know-issues-alert.html and known-issues.html

[amyleadem]

Note

I moved this check to component.html to limit code duplication

[amyleadem]

Note

Open to suggestions for naming this data key.

[amyleadem]

Note

github_label_url is not currently used. Eventually, we might need to bring this back because the github label names do not always line up with the component names, but I would prefer updating the label name instead. We can explore this later on if needed.

[mahoneycm]

This looks good to me! Left one comment about a potential future enhancement to allow multiple pages issues to be combined.

• Confirm that the date picker known issues appear on the date range picker page
• Confirm that all links in the known issues section point to the expected location
• Confirm that the known issues alert appears at the top of the date range picker page
• Confirm no regressions on other pages with known issues (character count, combo box, date picker, file input, input mask, validation)
• Confirm this code meets standards

[amyleadem]

Note

We need to update this changelog date before merge

[mejiaj]

Overall looks good. Added minor, optional, suggestions for clarity.

[mejiaj]

Suggested change

	- date: NNNN-NN-NN
	- date: 2024-04-30

[mejiaj]

Future enhancement

Create a reusable alert component.

uswds-site/_includes/component.html

Lines 8 to 17 in a968712

	{% if page.alert == true %}
	<div class="usa-alert margin-bottom-3 usa-alert--{{ page.alert-class }}">
	<div class="usa-alert__body">
	<h2 class="usa-alert__heading">{{ page.alert-heading }}</h2>
	<p class="usa-alert__text">
	{{ page.alert-content }}
	</p>
	</div>
	</div>
	{% endif %}