Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Add tooltip accessibility tests page #2646

Merged
merged 16 commits into from
Jun 7, 2024
Merged

USWDS-Site: Add tooltip accessibility tests page #2646

merged 16 commits into from
Jun 7, 2024

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Apr 30, 2024 •
edited
Loading

Summary

Added accessibility tests page for the tooltip component.

Important

We should update changelog dates before merge.

Related issue

Closes #2525

Preview link

Resources

Testing and review

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@amyleadem amyleadem marked this pull request as ready for review May 2, 2024 15:16
amyleadem
amyleadem commented May 2, 2024
View reviewed changes
Copy link
Contributor Author

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for review. I added comments with some open questions below. Please let me know if you need any changes.

_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/tooltip.yml Outdated
Comment on lines 71 to 78
- summary: Screen reader announces tooltip content.
summary_additional: |
When you focus on the tooltip trigger,
the screen reader announces the tooltip content.
test_status: pass
test_type: screen_reader
version_tested: 3.8.0
wcag_criterion: 1.3.1
Copy link
Contributor Author

@amyleadem amyleadem May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amycole501 @alex-hull @sarah-sch @finekatie

Note

I updated the summary and test status for 1.3.1 according to this conversation. I also removed the test for 4.1.2. Please let me know if you want any changes here!

amyleadem
amyleadem commented May 2, 2024
View reviewed changes
_data/changelogs/component-tooltip-accessibility.yml Outdated
type: component
changelogURL:
items:
- date: NNNN-NN-NN
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We should update changelog dates before merge.

amycole501
amycole501 approved these changes May 2, 2024
View reviewed changes
Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page reads well and covers the success criteria we tested, all good.

finekatie
finekatie approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.

  • Confirm that the main component page links to the accessibility tests page in the side navigation.

  • Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.

  • Confirm that the main component page shows the accessibility tests summary.

  • Check that accessibility tests page provides the correct counts for each test status type.

  • Confirm no visual issues.

  • Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

  • Confirm the test checklist summaries and data are accurate. - relying on Amy C and Alex H expertise on this one.

otherwise LGM!!

amycole501
amycole501 approved these changes May 10, 2024
View reviewed changes
Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three new checks added (two failing) read well to me. The page overall reads well. I couldn't identify any changes needed.

alex-hull
alex-hull approved these changes May 10, 2024
View reviewed changes
Copy link

@alex-hull alex-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fails look good (until we mark them as pass)!

sarah-sch
sarah-sch requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyleadem - I'm recommending a couple of tweaks. Thanks!

_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
@amyleadem amyleadem requested a review from sarah-sch May 13, 2024 17:21
mahoneycm
mahoneycm requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One update and one question for ya

_components/tooltip/accessibility-tests.md Outdated Show resolved Hide resolved
_data/accessibility-tests/tooltip.yml Show resolved Hide resolved
sarah-sch
sarah-sch approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving Amy L.'s tweaks to language for 1.4.13 tests added during review process.

@amyleadem
Copy link
Contributor Author

Putting this effort on hold until the fixes uswds/uswds#5919 and uswds/uswds#5909 are merged.

@mahoneycm mahoneycm mentioned this pull request May 20, 2024
Merged
@amyleadem
Copy link
Contributor Author

amyleadem commented May 31, 2024 •
edited
Loading

Everyone - I have moved this out of hold now that the tooltip fixes in 3.8.1 have been published. Please let me know if you need any changes.

amycole501
amycole501 approved these changes May 31, 2024
View reviewed changes
Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mahoneycm
mahoneycm requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested possible changes related to test failures and behaviors introduced in 3.8.1

_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/tooltip.yml Outdated Show resolved Hide resolved
mahoneycm
mahoneycm approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amyleadem amyleadem requested a review from thisisdano June 4, 2024 20:46
@thisisdano @mahoneycm
Update status and dates to current
e979c7e 
Co-authored-by: Charlie Mahoney <charlie.mahoney@bixal.com>
@thisisdano thisisdano merged commit d6091a8 into main Jun 7, 2024
11 checks passed
@thisisdano thisisdano deleted the al-a11y-tests-tooltip branch June 7, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finekatie finekatie finekatie approved these changes

@amycole501 amycole501 amycole501 approved these changes

@sarah-sch sarah-sch sarah-sch approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

@thisisdano thisisdano thisisdano approved these changes

@alex-hull alex-hull Awaiting requested review from alex-hull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CC a11y: publish Tooltip checklist - create PR
7 participants
@amyleadem @thisisdano @mahoneycm @sarah-sch @amycole501 @alex-hull @finekatie