USWDS-Site: Add tooltip accessibility tests page #2646
Conversation
amyleadem
left a comment
amyleadem
left a comment
There was a problem hiding this comment.
This is ready for review. I added comments with some open questions below. Please let me know if you need any changes.
| - summary: Screen reader announces tooltip content. | ||
| summary_additional: | | ||
| When you focus on the tooltip trigger, | ||
| the screen reader announces the tooltip content. | ||
| test_status: pass | ||
| test_type: screen_reader | ||
| version_tested: 3.8.0 | ||
| wcag_criterion: 1.3.1 |
There was a problem hiding this comment.
@amycole501 @alex-hull @sarah-sch @finekatie
Note
I updated the summary and test status for 1.3.1 according to this conversation. I also removed the test for 4.1.2. Please let me know if you want any changes here!
amyleadem
requested review from
alex-hull,
amycole501,
finekatie,
mahoneycm and
sarah-sch
| type: component | ||
| changelogURL: | ||
| items: | ||
| - date: NNNN-NN-NN |
There was a problem hiding this comment.
Important
We should update changelog dates before merge.
amycole501
left a comment
amycole501
left a comment
There was a problem hiding this comment.
The page reads well and covers the success criteria we tested, all good.
finekatie
left a comment
finekatie
left a comment
There was a problem hiding this comment.
-
Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
-
Confirm that the main component page links to the accessibility tests page in the side navigation.
-
Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
-
Confirm that the main component page shows the accessibility tests summary.
-
Check that accessibility tests page provides the correct counts for each test status type.
-
Confirm no visual issues.
-
Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.
-
Confirm the test checklist summaries and data are accurate. - relying on Amy C and Alex H expertise on this one.
otherwise LGM!!
amycole501
left a comment
amycole501
left a comment
There was a problem hiding this comment.
The three new checks added (two failing) read well to me. The page overall reads well. I couldn't identify any changes needed.
alex-hull
left a comment
alex-hull
left a comment
There was a problem hiding this comment.
I think the fails look good (until we mark them as pass)!
sarah-sch
left a comment
sarah-sch
left a comment
There was a problem hiding this comment.
@amyleadem - I'm recommending a couple of tweaks. Thanks!
mahoneycm
left a comment
mahoneycm
left a comment
There was a problem hiding this comment.
Looking good! One update and one question for ya
sarah-sch
left a comment
sarah-sch
left a comment
There was a problem hiding this comment.
Approving Amy L.'s tweaks to language for 1.4.13 tests added during review process.
|
Putting this effort on hold until the fixes uswds/uswds#5919 and uswds/uswds#5909 are merged. |
|
Everyone - I have moved this out of hold now that the tooltip fixes in 3.8.1 have been published. Please let me know if you need any changes. |
mahoneycm
left a comment
mahoneycm
left a comment
There was a problem hiding this comment.
Requested possible changes related to test failures and behaviors introduced in 3.8.1
Co-authored-by: Charlie Mahoney <charlie.mahoney@bixal.com>
Summary
Added accessibility tests page for the tooltip component.
Important
We should update changelog dates before merge.
Related issue
Closes #2525
Preview link
Resources
Testing and review