Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Add text input accessibility tests page #2697

Merged
merged 12 commits into from
Jun 19, 2024
Merged

USWDS-Site - Add text input accessibility tests page #2697

merged 12 commits into from
Jun 19, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented May 29, 2024 •
edited
Loading

Summary

Added accessibility tests page for the text input component.

Important

Build errors due to broken links will be resolved in #2692
We should update changelog dates before merging.

Related issue

Closes #2628

Preview link

Resources

Testing and review

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm new 1.3.3 and 1.3.4 wcag criterion is accurate and link works
  8. Confirm no visual issues.
  9. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@mahoneycm mahoneycm marked this pull request as ready for review May 29, 2024 16:32
finekatie
finekatie reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment about a WCAG label. So far so good otherwise.

_includes/accessibility-tests/wcag-details.html Outdated Show resolved Hide resolved
amyleadem
amyleadem requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I added some questions and comments below. Let me know if you have any questions.

_data/accessibility-tests/text-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/text-input.yml Outdated Show resolved Hide resolved
_data/changelogs/component-text-input-accessibility.yml Show resolved Hide resolved
_data/accessibility-tests/text-input.yml Outdated Show resolved Hide resolved
@finekatie finekatie removed the request for review from sarah-sch June 5, 2024 21:33
finekatie
finekatie approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amyleadem
amyleadem requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Added just a couple of small questions in the comments.

_data/accessibility-tests/text-input.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/text-input.yml Outdated Show resolved Hide resolved
amyleadem and others added 3 commits June 6, 2024 16:25
@amyleadem
Merge branch 'main' of https://github.com/uswds/uswds-site into cm-a1…
647c94c 
…1y-checklist-text-input
@mahoneycm @amyleadem
Update _data/accessibility-tests/text-input.yml
e81b702 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm @amyleadem
Update _data/accessibility-tests/text-input.yml
07d9511 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm mahoneycm requested a review from amyleadem June 7, 2024 14:50
@mahoneycm
Copy link
Contributor Author

@amyleadem I liked the summary changes and merged them! Ready for re-review 👍

amyleadem
amyleadem approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks! Before merge, I'd like to have @amycole501 or @alex-hull sign off on the updated summary for 1.3.3.

amycole501
amycole501 approved these changes Jun 11, 2024
View reviewed changes
Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions that use visual cues also provide non-visual instruction. If you use visual cues like shapes or locations to describe controls (e.g., “input below”), also provide extra instructions explaining how to access the text input. This way, users who can’t see shapes or locations can still understand how to use the controls.

@mahoneycm
Copy link
Contributor Author

Ready for your review @thisisdano !

mahoneycm
mahoneycm commented Jun 13, 2024
View reviewed changes
_data/changelogs/component-text-input.yml Outdated
Comment on lines 8 to 12
- date: NNNN-NN-NN
summary: Added WCAG compliance tag and accessibility test status section.
affectsGuidance: true
githubPr: 2697
githubRepo: uswds-site
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Flagging that both changelog dates needs to be updated before merge

@amyleadem
Copy link
Contributor

amyleadem commented Jun 14, 2024 •
edited
Loading

Note: I just moved this issue to fed final since it looks like it is ready for fed review

thisisdano
thisisdano reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog publish dates

_data/changelogs/component-text-input-accessibility.yml Outdated Show resolved Hide resolved
_data/changelogs/component-text-input.yml Outdated Show resolved Hide resolved
@thisisdano thisisdano merged commit e1b13bc into main Jun 19, 2024
11 checks passed
@thisisdano thisisdano deleted the cm-a11y-checklist-text-input branch June 19, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finekatie finekatie finekatie approved these changes

@amycole501 amycole501 amycole501 approved these changes

@amyleadem amyleadem amyleadem approved these changes

@thisisdano thisisdano thisisdano approved these changes

@mejiaj mejiaj Awaiting requested review from mejiaj

@alex-hull alex-hull Awaiting requested review from alex-hull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CC a11y: publish text input checklist - create PR
6 participants
@mahoneycm @amyleadem @thisisdano @amycole501 @alex-hull @finekatie