-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add select accessibility tests page #2702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for review. Please review the questions in the comments below. Let me know if you have any questions.
_data/accessibility-tests/select.yml
Outdated
| When you are using a screen reader, | ||
| you will know the common purpose of the select option (eg., date, time, state). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-hull @amycole501 @sarah-sch @finekatie
Wondering if we can provide a more specific example for clarity
| When you are using a screen reader, | |
| you will know the common purpose of the select option (eg., date, time, state). | |
| When you are using a screen reader, | |
| you will hear the common purpose of the select option (eg., "Select your state"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that revision especially since select elements are often used for a variety of common lists. I think state, day, time are all good options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to "eg., "Select your state"" in ef4aa40
adding missing period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed a change to add a missing period. Have a question for a11y team about whether we're referencing the correct WCAG criterion on the test "Content doesn’t change until the user takes an action to change it."
|
@amycole501 @alex-hull @sarah-sch @finekatie @mahoneycm I believe I have addressed all your comments. This is ready for your re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small changes for consistency with recent test pages.
Potentially non-blocker as these are changing over time. We discussed doing an audit in the future to catch inconsistencies but it'd be nice to get ahead of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything has been resolved that I was asked to look at, so I give the all clear!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add changelog publish dates
Summary
Added accessibility tests page for the select component.
Important
We should update changelog dates before merge.
Related issue
Closes #2666
Preview link
Resources
Testing and review