Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add known issues section to memorable date page #2716

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jun 18, 2024

Summary

Added a known issues section to the memorable date component page.

Important

We should update the changelog dates before merge

Note

The build errors will resolve when we merge either #2721 or #2731.

Related issue

Closes #2682

Preview link

Memorable date page

Testing and review

  • Confirm a known issues section appears on the memorable date page
  • Confirm the info alert is present at the top of the memorable date page
  • On the known issues list item:
    • Confirm that the issue descriptions are accurate
    • Confirm that GitHub links work as expected
    • Confirm there are no spelling or grammar issues
  • Confirm the changelog entry is present and accurate

@amyleadem amyleadem changed the title Add known issues for memorable date USWDS-Site: Add known issues section to memorable date page Jun 18, 2024
@amyleadem amyleadem marked this pull request as ready for review June 18, 2024 23:05
Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great - I just have one correction to suggest before merging.

The second issue copy should be changed from "Users expected to be able to search the month input by either name or number but could do neither." to "Users expected to be able to search the month input by either name or number but could only search by number."

@amyleadem
Copy link
Contributor Author

Thanks! I updated the summary in 704f417. Let me know if you need any other changes.

@amyleadem amyleadem requested a review from jaclinec June 26, 2024 21:57
Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - approved! Thanks!

@amyleadem amyleadem requested a review from mahoneycm June 26, 2024 22:15
@amyleadem
Copy link
Contributor Author

@finekatie and @mahoneycm This is ready for your review!

Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing a new row for the change log - does that show up after you publish?

Wondering about the phrase "users experienced friction" in the third issue. I would suggest something plainer, but I see the same language is in the GH issue, so I'll leave it be.

Other than these two things, LGTM :)

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amyleadem
Copy link
Contributor Author

@finekatie It looked like we had a build failure on the page preview. The changelog should be visible now. Let me know if you need any changes!

@finekatie finekatie self-requested a review June 27, 2024 17:09
@finekatie
Copy link
Contributor

@finekatie It looked like we had a build failure on the page preview. The changelog should be visible now. Let me know if you need any changes!

Sorry - I think I re-requested review by accident? I approve and LGTM :)

Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thisisdano thisisdano merged commit c8690b3 into main Nov 6, 2024
11 checks passed
@thisisdano thisisdano deleted the al-known-issues-mem-date branch November 6, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS - Site - Known issues: Add known issues to memorable date component
5 participants