-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add known issues section to memorable date page #2716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great - I just have one correction to suggest before merging.
The second issue copy should be changed from "Users expected to be able to search the month input by either name or number but could do neither." to "Users expected to be able to search the month input by either name or number but could only search by number."
|
Thanks! I updated the summary in 704f417. Let me know if you need any other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect - approved! Thanks!
|
@finekatie and @mahoneycm This is ready for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing a new row for the change log - does that show up after you publish?
Wondering about the phrase "users experienced friction" in the third issue. I would suggest something plainer, but I see the same language is in the GH issue, so I'll leave it be.
Other than these two things, LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…own-issues-mem-date
|
@finekatie It looked like we had a build failure on the page preview. The changelog should be visible now. Let me know if you need any changes! |
Sorry - I think I re-requested review by accident? I approve and LGTM :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…own-issues-mem-date
Summary
Added a known issues section to the memorable date component page.
Important
We should update the changelog dates before merge
Note
The build errors will resolve when we merge either #2721 or #2731.
Related issue
Closes #2682
Preview link
Memorable date page
Testing and review