USWDS-Site - Bug: Add missing comma to utils example #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
commented
Jun 26, 2024
| @@ -54,7 +54,7 @@ The following are practical actions you can take: | |||
| - [Usability testing with Steve Krug](https://digital.gov/event/2018/06/14/usability-testing-with-steve-krug/) [digital.gov] | |||
| - [18F's human-centered design methods](https://methods.18f.gov/) [methods.18f.gov] | |||
| - [18F's research guidelines](https://handbook.18f.gov/research-guidelines/) [handbook.18f.gov] | |||
| - [Interview checklist](https://methods.18f.gov/interview-checklist/) [methods.18f.gov] | |||
There was a problem hiding this comment.
Note
HTMLProofer flagged this link as broken.
mejiaj
commented
Jun 26, 2024
| @@ -54,7 +54,7 @@ The following are practical actions you can take: | |||
| - [Usability testing with Steve Krug](https://digital.gov/event/2018/06/14/usability-testing-with-steve-krug/) [digital.gov] | |||
| - [18F's human-centered design methods](https://methods.18f.gov/) [methods.18f.gov] | |||
| - [18F's research guidelines](https://handbook.18f.gov/research-guidelines/) [handbook.18f.gov] | |||
| - [Interview checklist](https://methods.18f.gov/interview-checklist/) [methods.18f.gov] | |||
| - [Interview checklist](https://guides.18f.gov/ux-guide/interview-checklist/) [methods.18f.gov] | |||
There was a problem hiding this comment.
| Before | After |
|---|---|
 Web archive link |
 New URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Utils example is missing a comma that could lead to subsequent settings being ignored.
On Utilities page - Source →
Related issue
Originally reported in slack →. Thanks @bmartinez287!
Preview link
Preview link: Utilities →
Solution
Added a comma to color utility in code example.