USWDS-Site - a11y: publish Identifier checklist #2754
Conversation
There was a problem hiding this comment.
Hi @cathybaptista , I had comments and a possible text correction. I tagged everyone in the comments - hope they can see!
Merge branch 'main' into cb-publish-identifier-checklist
There was a problem hiding this comment.
Hey @cathybaptista ! Great work getting these pages added and including the changelogs! They're looking solid.
It looks like we're missing a couple tests from the checklist. I also left a couple small changes for consistency. Let me know if you have any questions!
There was a problem hiding this comment.
Looking good @cathybaptista! I had just a couple of small tweaks in the comments below.
There was a problem hiding this comment.
Looks good to me! Thanks for your work on this, @cathybaptista.
There was a problem hiding this comment.
Looks great!
praise: Thank you to @cathybaptista for getting this most of the way there and for @amyleadem getting it across the finish line 🥳
|
Looks good from my end as well. Great job! |
|
@amycole501 If everything looks good to you, can you approve the PR? Thanks! |
Summary
Added accessibility tests page for the Identity component to inform users of accessibility test results.
Important
We need to update the changelog dates before merge.
Related issue
Closes #2669
Preview link
Link to Identifier component
Problem statement
Users need an clear and consistent way to check results of accessibility tests run on USWDS components.
Solution
This page provides user with accessibility test results run on the Identifier component in a consistent format.
Major changes
n/a
Testing and review
Follow these steps:
Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
Confirm that the main component page links to the accessibility tests page in the side navigation.
Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
Confirm that the main component page shows the accessibility tests summary.
Check that accessibility tests page provides the correct counts for each test status type.
Confirm the test checklist summaries and data are accurate.
Confirm no visual issues.
Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch ismain).npm run prettier:scssto format any Sass updates.npm testand confirm that all tests pass.