USWDS-Site - Add header accessibility tests page #2761
Conversation
RachelCorsino
requested review from
mejiaj,
amyleadem,
mahoneycm and
cathybaptista
There was a problem hiding this comment.
Thanks for your work here @RachelCorsino. I've added some comments with change requests below. Please let me know if you have any questions!
There was a problem hiding this comment.
I noticed that there is no alert on the accessibility section of the main page that points to the accessibility tests. Can you add it to this file like you did on the list component page? It should be possible by adding the following include:
{% include accessibility-tests/a11y-note.html %}
There was a problem hiding this comment.
Resolved in 2aae0a9
There was a problem hiding this comment.
Looks like we need to take a slightly different approach for this one since header.html is built with a different structure. Can you remove accessibility.md and instead add the include to header.html right below the "Header accessibility" element?
Edit: We might need to make some edits to a11y-note.html to make the link in the a11y note work. We can talk through the best options there.
There was a problem hiding this comment.
Resolved in 6eece60
Let me know if I did this right!
There was a problem hiding this comment.
Thanks @RachelCorsino!
That note typically belongs at the top of our other component accessibility guidance, so I took the liberty of moving the a11y-note to right below the "Header accessibility" header in ba8d7ba.
In that commit, I also updated the url in a11y-note.html so that it doesn't rely on componentKey from component.html. This should allow a11y-note.html to build the correct url. We should confirm that this doesn't have a negative effect on the a11y note links for existing pages like character count or accordion.
|
@RachelCorsino Also, can you update the PR title to match the format: "USWDS-Site - Add [component name] accessibility tests page" |
RachelCorsino
changed the title
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Title has been updated! |
There was a problem hiding this comment.
Thanks for those updates @RachelCorsino. I've added some comments with some new discoveries and suggestions. Happy to work together on adding the test status table to the main component page - just let me know.
There was a problem hiding this comment.
Looks like we need to take a slightly different approach for this one since header.html is built with a different structure. Can you remove accessibility.md and instead add the include to header.html right below the "Header accessibility" element?
Edit: We might need to make some edits to a11y-note.html to make the link in the a11y note work. We can talk through the best options there.
…s/uswds-site into rc-publish-header-checklist merging updates/fixes from pr comments
- Help the component find the data for pages not built on component.html
…blish-header-checklist
There was a problem hiding this comment.
Note
Added additional assignments here because header.html does not inherit these assignments from component.html.
There was a problem hiding this comment.
Note
Updated the url assignment here because some pages (like header.html) do not inherit componentKey from component.html. We should confirm that this does not have a negative effect on existing pages like character count or accordion.
There was a problem hiding this comment.
Looks good to me! Thanks for your persistence on this one, @RachelCorsino
…blish-header-checklist
Summary
Added accessibility tests page for the header component.
Related issue
Closes #2739
Preview link
Testing and review
Follow these steps: