Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Added checkbox accessibility test page #2803

Merged
merged 8 commits into from
Sep 18, 2024
Merged

USWDS-Site: Added checkbox accessibility test page #2803

merged 8 commits into from
Sep 18, 2024

Conversation

RachelCorsino
Copy link
Contributor

@RachelCorsino RachelCorsino commented Sep 3, 2024 •
edited
Loading

Summary

Added accessibility test page for checkbox component

Related issue

Closes #2799

Preview link

Preview link:
Checkbox Component Page
Checkbox Accessibility Tests Page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@RachelCorsino RachelCorsino changed the title initial commit for checkbox checklist USWDS-Site: Added checkbox accessibility test page Sep 3, 2024
amyleadem
amyleadem requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RachelCorsino Thanks for getting this set up so quickly! I tagged you in a couple of comments below - they should be easy fixes. I also tagged @finekatie @alex-hull and @amycole501 in some comments about some of the summaries. Let me know if you have any questions!

_components/checkbox/checkbox.md Outdated Show resolved Hide resolved
_data/accessibility-tests/checkbox.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/checkbox.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/checkbox.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/checkbox.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/checkbox.yml Outdated Show resolved Hide resolved
@finekatie
Copy link
Contributor

Hi @amyleadem , I saw that I was added to this but I appear to now be removed. Do you still need my review? Apologies for not being able to get to it sooner.

@finekatie finekatie mentioned this pull request Sep 6, 2024
Open
6 tasks
amyleadem
amyleadem requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @RachelCorsino! I discovered one other item to fix, highlighted in the comment below.

@finekatie, I just tagged you as a reviewer on this PR. We made some updates to the summaries. Can you confirm that they all meet standards?

_data/accessibility-tests/checkbox.yml Outdated Show resolved Hide resolved
finekatie
finekatie approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve!

@amyleadem amyleadem marked this pull request as ready for review September 6, 2024 22:10
amyleadem
amyleadem approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@amycole501
Copy link

The first focus indicator check under "keyboard" has the wrong WCAG criteria. It should be WCAG Focus visible AA https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html

@RachelCorsino
Copy link
Contributor Author

The first focus indicator check under "keyboard" has the wrong WCAG criteria. It should be WCAG Focus visible AA https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html

Resolved in 6209524.

@amyleadem amyleadem mentioned this pull request Sep 18, 2024
Merged
@thisisdano thisisdano merged commit 869716f into main Sep 18, 2024
6 of 8 checks passed
@thisisdano
Copy link
Member

Merging over htmlproofer false positives in Circle.

@thisisdano thisisdano deleted the rc-publish-checkbox-checklist branch September 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyleadem amyleadem amyleadem approved these changes

@finekatie finekatie finekatie approved these changes

@amycole501 amycole501 amycole501 approved these changes

@thisisdano thisisdano thisisdano approved these changes

@cathybaptista cathybaptista Awaiting requested review from cathybaptista

@alex-hull alex-hull Awaiting requested review from alex-hull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CC a11y: publish checkbox checklist - create PR
6 participants
@RachelCorsino @finekatie @amycole501 @thisisdano @amyleadem @alex-hull