Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Added in page navigation accessibility test page #2863

Merged
merged 12 commits into from
Oct 16, 2024
Merged

USWDS-Site: Added in page navigation accessibility test page #2863

merged 12 commits into from
Oct 16, 2024

Conversation

RachelCorsino
Copy link
Contributor

@RachelCorsino RachelCorsino commented Oct 7, 2024 •
edited
Loading

Summary

Added accessibility test page for in page navigation component

Related issue

Closes #2856

Preview link

Preview link: In-page Navigation Component Page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@RachelCorsino RachelCorsino marked this pull request as ready for review October 7, 2024 16:30
mejiaj
mejiaj requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RachelCorsino. The pages look good and no a11y issues found.

Minor comments on code formatting below.

_components/in-page-navigation/accessibility-tests.md Outdated Show resolved Hide resolved
_components/in-page-navigation/accessibility-tests.md Outdated Show resolved Hide resolved
_components/in-page-navigation/in-page-navigation.md Outdated Show resolved Hide resolved
_data/accessibility-tests/in-page-navigation.yml Show resolved Hide resolved
_data/changelogs/component-in-page-navigation-accessibility.yml Outdated Show resolved Hide resolved
cathybaptista
cathybaptista previously requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@cathybaptista cathybaptista left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Rachel. I'm being super picky with this one! Can you verify that for many of these items the correct last version tested is 3.8.2? I know it's picky, but I think on 8/8 the last version was 3.8.1, right? the date for 3.8.2 is 8/9.

Also, please check the 2.4.7 criteria name(s). There are three of them, and they all say "Focus Visible," but I think(?) one is "Headings and Labels" and one is "Link Purpose." :)

@RachelCorsino
Copy link
Contributor Author

Hi, Rachel. I'm being super picky with this one! Can you verify that for many of these items the correct last version tested is 3.8.2? I know it's picky, but I think on 8/8 the last version was 3.8.1, right? the date for 3.8.2 is 8/9.

Also, please check the 2.4.7 criteria name(s). There are three of them, and they all say "Focus Visible," but I think(?) one is "Headings and Labels" and one is "Link Purpose." :)

Good catches @cathybaptista! These have all been resolved in 9592e28

mahoneycm
mahoneycm requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes needed for cleanup. I only flagged one file for replacing in page navigation with in-page navigation but if you could make sure the other files match that would be great!

Let me know if you have any questions.

_components/in-page-navigation/accessibility-tests.md Outdated Show resolved Hide resolved
_components/in-page-navigation/in-page-navigation.md Outdated Show resolved Hide resolved
_includes/accessibility-tests/wcag-details.html Outdated Show resolved Hide resolved
mejiaj
mejiaj approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I've made small formatting tweaks, mainly spacing and capitalized the subnav link.

_data/changelogs/component-in-page-navigation-accessibility.yml Outdated
title: In-page navigation accessibility tests
type: component
items:
- date: NNNN-NN-NN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: Will need to add date before final merge.

_data/changelogs/component-in-page-navigation.yml Outdated
@@ -2,6 +2,11 @@ title: In-page navigation
type: component
changelogURL:
items:
- date: NNNN-NN-NN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: Will need to add date before final merge.

alex-hull
alex-hull requested changes Oct 16, 2024
View reviewed changes
Copy link

@alex-hull alex-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criteria 2.4.8 under the general sections should be marked as conditional versus marked as pass. Basing this on previous discussion. Everything else looks good!

mahoneycm
mahoneycm approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alex-hull
alex-hull approved these changes Oct 16, 2024
View reviewed changes
Copy link

@alex-hull alex-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@thisisdano thisisdano dismissed cathybaptista’s stale review October 16, 2024 20:34

These have all been resolved in 9592e28

@thisisdano thisisdano merged commit 720384c into main Oct 16, 2024
11 checks passed
@thisisdano thisisdano deleted the rc-in-page-nav-checklist branch October 16, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-hull alex-hull alex-hull approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

@thisisdano thisisdano thisisdano approved these changes

@mejiaj mejiaj mejiaj approved these changes

@cathybaptista cathybaptista Awaiting requested review from cathybaptista

@amycole501 amycole501 Awaiting requested review from amycole501

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CC a11y: publish in-page navigation checklist - create PR
6 participants
@RachelCorsino @mejiaj @thisisdano @mahoneycm @alex-hull @cathybaptista