USWDS-Site: Added pagination accessibility test page #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @RachelCorsino, looks good.
I've added some formatting fixes and notes to update the placeholder date before we merge.
| title: Pagination accessibility tests | ||
| type: component | ||
| items: | ||
| - date: NNNN-NN-NN |
| githubPr: 4175 | ||
| githubRepo: uswds | ||
| versionUswds: 2.12.0 | ||
| - date: NNNN-NN-NN |
There was a problem hiding this comment.
chore: Need to add date.
Suggested change
| - date: NNNN-NN-NN | |
| - date: NNNN-NN-NN |
mahoneycm
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Looking good! Found an incorrect criterion number to be updated and asked a question of our a11y team
Testing checklist
- Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
- Confirm that the main component page links to the accessibility tests page in the side navigation.
- Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
- Confirm that the main component page shows the accessibility tests summary.
- Check that accessibility tests page provides the correct counts for each test status type.
- Confirm the test checklist summaries and data are accurate.
- “Screen reader announces role values” should be criterion
4.1.2 Name, role, value - Should
2.4.8be conditional as well?
- “Screen reader announces role values” should be criterion
- Confirm no visual issues.
- Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.
mahoneycm
approved these changes
Oct 16, 2024
thisisdano
reviewed
Oct 16, 2024
thisisdano
reviewed
Oct 16, 2024
thisisdano
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added accessibility test page for pagination component
Related issue
Closes #2858
Preview link
Preview link: Pagination Component Page
Testing and review
Follow these steps: