Skip to content

Conversation

@mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Oct 21, 2024

Summary

Add focus trap guidance. Updated changelog and content guidance GDOC πŸ”’

Related issue

Closes #2840.

Preview link

Preview link β†’

Add focus trap guidance.
@mejiaj mejiaj marked this pull request as ready for review October 21, 2024 17:33
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@finekatie
Copy link
Contributor

Hey @mejiaj , does this need a change log update?

@mejiaj
Copy link
Contributor Author

mejiaj commented Oct 22, 2024

@finekatie good point. I'll make that change.

@mejiaj mejiaj marked this pull request as draft October 22, 2024 13:16
Add changelog entry to Modal focus trap guidance.
@mejiaj mejiaj marked this pull request as ready for review October 22, 2024 13:44
@mejiaj mejiaj requested a review from finekatie October 22, 2024 13:44
@mejiaj
Copy link
Contributor Author

mejiaj commented Oct 22, 2024

@finekatie ready for another look, I've updated the changelog and guidance in gdoc.

image

Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thisisdano thisisdano merged commit 1d8aac7 into main Nov 6, 2024
11 checks passed
@thisisdano thisisdano deleted the jm-modal-a11y-focus-guidance branch November 6, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USWDS-Site - Feature: Add modal accessibility guidance for trapping focus

5 participants