-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Added memorable date accessibility test page #2919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I left a couple potential changes related to past and present criterion discussions. Might need some feedback from the team before we move forward
…morable-date-checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for taking this on @RachelCorsino. Just a couple small tweaks and questions below.
Edit: Can you also resolve the merge conflicts in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! One small polish change and this should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this @RachelCorsino.
@amycole501 and/or @alex-hull, can you review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
e980bfa
added changelog date
added changelog date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; added changelog date
|
Couple 404s are showing up in HTML proofer if maybe @RachelCorsino could take a look:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RachelCorsino can you fix indents? There should also be an empty line at the end of files.
…s/uswds-site into rc-memorable-date-checklist
Summary
Added accessibility test page for memorable date component
Important
We need to update the changelog date before merge.
Related issue
Closes #2875
Preview link
Memorable date
Memorable date accessibility tests
Testing and review
Follow these steps: