Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Added memorable date accessibility test page #2919

Merged
merged 16 commits into from
Nov 21, 2024

Conversation

RachelCorsino
Copy link
Contributor

@RachelCorsino RachelCorsino commented Oct 28, 2024

Summary

Added accessibility test page for memorable date component

Important

We need to update the changelog date before merge.

Related issue

Closes #2875

Preview link

Memorable date
Memorable date accessibility tests

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@RachelCorsino RachelCorsino marked this pull request as ready for review October 31, 2024 20:14
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left a couple potential changes related to past and present criterion discussions. Might need some feedback from the team before we move forward

_data/accessibility-tests/memorable-date.yml Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Outdated Show resolved Hide resolved
.snyk Outdated Show resolved Hide resolved
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for taking this on @RachelCorsino. Just a couple small tweaks and questions below.

Edit: Can you also resolve the merge conflicts in this PR?

_data/accessibility-tests/memorable-date.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/memorable-date.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One small polish change and this should be good to go

_data/accessibility-tests/memorable-date.yml Show resolved Hide resolved
@RachelCorsino RachelCorsino requested a review from a team as a code owner November 14, 2024 15:27
mahoneycm
mahoneycm previously approved these changes Nov 14, 2024
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks!

amyleadem
amyleadem previously approved these changes Nov 15, 2024
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @RachelCorsino.

@amycole501 and/or @alex-hull, can you review?

amycole501
amycole501 previously approved these changes Nov 15, 2024
Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@finekatie finekatie self-requested a review November 15, 2024 21:10
finekatie
finekatie previously approved these changes Nov 15, 2024
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

annepetersen
annepetersen previously approved these changes Nov 19, 2024
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; added changelog date

@annepetersen
Copy link
Contributor

Couple 404s are showing up in HTML proofer if maybe @RachelCorsino could take a look:

For the Links > External check, the following failures were found:

mejiaj
mejiaj previously requested changes Nov 19, 2024
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RachelCorsino can you fix indents? There should also be an empty line at the end of files.

@thisisdano thisisdano merged commit ddd8692 into main Nov 21, 2024
11 checks passed
@thisisdano thisisdano deleted the rc-memorable-date-checklist branch November 21, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site: Publish memorable date accessibility checklist page
9 participants