Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Added time picker accessibility test page #2921

Merged
merged 8 commits into from
Nov 7, 2024
Merged

USWDS-Site: Added time picker accessibility test page #2921

merged 8 commits into from
Nov 7, 2024

Conversation

RachelCorsino
Copy link
Contributor

@RachelCorsino RachelCorsino commented Oct 28, 2024 •
edited by amyleadem
Loading

Summary

Added accessibility test page for time picker component

Related issue

Closes #2876

Preview link

Time Picker
Time picker accessibility tests

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@RachelCorsino RachelCorsino marked this pull request as ready for review October 31, 2024 21:01
@RachelCorsino
Copy link
Contributor Author

I tried running npm run proof to fix build errors and it doesn't look like it worked... let me know if I'm missing something to fix those errors!

@RachelCorsino RachelCorsino requested review from cathybaptista and removed request for mejiaj October 31, 2024 21:15
mahoneycm
mahoneycm requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed an issue with two separate 3.3.2 items. Other than that just some small version changes.

Polish: After you update the version numbers, can you make sure the tests are in numerical order in each testing category?

Thanks @RachelCorsino !

.snyk Outdated Show resolved Hide resolved
_data/accessibility-tests/time-picker.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/time-picker.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/time-picker.yml Outdated Show resolved Hide resolved
mahoneycm
mahoneycm approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Rachel!

mlloydbixal
mlloydbixal approved these changes Nov 7, 2024
View reviewed changes
Copy link

@mlloydbixal mlloydbixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RachelCorsino RachelCorsino requested review from thisisdano and removed request for amyleadem and cathybaptista November 7, 2024 19:12
annepetersen
annepetersen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annepetersen annepetersen merged commit 4b1eda2 into main Nov 7, 2024
11 checks passed
@annepetersen annepetersen deleted the rc-time-picker-checklist branch November 7, 2024 22:32
@amyleadem amyleadem mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

@annepetersen annepetersen annepetersen approved these changes

@thisisdano thisisdano Awaiting requested review from thisisdano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USWDS-Site: Publish time picker accessibility checklist page
4 participants
@RachelCorsino @annepetersen @mahoneycm @mlloydbixal