USWDS-Site: Updating links per Design Principles audit#3053
USWDS-Site: Updating links per Design Principles audit#3053annepetersen merged 16 commits intomainfrom
Conversation
After extensive audit of links to determine relevance of links, edits can be made to this page.
finekatie
requested review from
amycole501,
annepetersen,
jaclinec and
thisisdano
finekatie
changed the title
finekatie
changed the title
finekatie
changed the title
jaclinec
left a comment
jaclinec
left a comment
There was a problem hiding this comment.
Finished my review and added my comments to the page draft since it's probably clearer there. There was one link in the draft that I didn't see in the preview (18F User Experience Guide — Research ), and I commented on 3 other links - one that I think we decided should be removed, one that was duplicative, and one where I wondered if there was a more up-to-date resource to link to.
Made a few corrections per comments from JC in the draft doc.
|
@jaclinec - I made updates per your comments in the draft. Please review when you are up to it. |
|
@finekatie everything looks good now - thanks! |
|
I reviewed links to make sure nothing was broken due to recent policy changes. All looks good. @annepetersen and @thisisdano this is ready for FFR. |
|
amycole501
left a comment
amycole501
left a comment
There was a problem hiding this comment.
I read over and clicked all the links focusing on the a11y section. The only slight oddity is that when I click the plain language link I see a bunch of weird code (maybe tracking code?) in the URL
1.Try clicking the "learn about writing in plain language" link under "further reading" in the "embrace accessibility" section.
- Then look at your browser bar to see the URL or see below:
It didn't seem to do that on the other plain language link on the page. I also deleted that code and the URL works fine. So maybe just a weird glitch (?)
jaclinec
left a comment
jaclinec
left a comment
There was a problem hiding this comment.
I just reviewed it and all looks good except 2 links at the end of the page, which are broken:
|
Note: More 404 errors occurring. Links being audited again and corrections will be made. Will resubmit this for review once updates made to the branch. |
| - [Delivering Excellent, Equitable, and Secure Federal Services and Customer Experience](https://bidenadministration.archives.performance.gov/pma/cx/) [performance.gov] | ||
| - [Tips for Starting Your Customer Experience Journey](https://www.performance.gov/cx/blog/tips-for-starting-your-customer-experience-journey/) [performance.gov] | ||
| - [OMB Circular A-11 Section 280: Managing Customer Experience and Improving Service Delivery](https://www.performance.gov/cx/assets/files/a11_2021-FY22.pdf) [performance.gov] | ||
| - [OMB Circular A-11 Section 280: Managing Customer Experience and Improving Service Delivery](https://www.whitehouse.gov/wp-content/uploads/2018/06/s280.pdf)(PDF) [performance.gov] |
There was a problem hiding this comment.
@finekatie
issue: Looks like this link is 404-ing now
There was a problem hiding this comment.
Hey @jaclinec , should we go back to the old one or remove entirely? https://www.performance.gov/cx/assets/files/a11_2021-FY22.pdf
There was a problem hiding this comment.
Discussed with Jacline. Removing version.
…signprinciples-updt
There was a problem hiding this comment.
Looking good, just found a couple of possible small copy tweaks in the comments below.
- Confirm the code meets standards
- Confirm the branch is up to date and tests pass
- Confirm no regressions in content display
- Confirm copy updates match pre-existing conventions
- Confirm the changelog is present and accurate
Note that I did not compare the changes to the edit doc (let me know if you want me to do that)
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
amyleadem
left a comment
amyleadem
left a comment
There was a problem hiding this comment.
LGTM from a engineering perspective!
jaclinec
left a comment
jaclinec
left a comment
There was a problem hiding this comment.
Everything looks good to me! :)
|
Hi @amycole501 , do you want to complete your review? |
|
Reviewed last month approved. |
updating changelog
annepetersen
dismissed stale reviews from jaclinec and amyleadem
via
0ac46ce
|
The HTML Proofer is preventing merge on this because of the broken links that were fixed in #3092. Could I get a dev to update the branch? Tagging @amyleadem since you'd been handling this one to this point |
…signprinciples-updt
|
The build errors here should be fixed by #3121 |
|
@annepetersen Tests are passing again. This is ready for your review. |
5 participants
Summary
After extensive audit of links to determine relevance of links, edits can be made to this page.
Important
This page does not have a changelog - one needs to be added
Related issue
Closes #3054 / #2573
Preview link
Design principles page
Problem statement
Resources linked throughout the Design Principles page were aging or no longer relevant.
Solution
UX, CS, A11y teams and feds to audit and analyze relevance and timeliness of links, update and add new as needed.
Related documents:
Audit
Page draft with edits
Testing and review
Need reviews to compare to the page draft make sure links work and content is clean and clear.